Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small modifications to clarify NXmpes #266

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Conversation

lukaspie
Copy link
Collaborator

@lukaspie lukaspie commented Jul 9, 2024

  • clarify that the explicit axis names are not exhaustive and other names are allowed
  • rename all environments in NXmpes/NXsample to *_env to distinguish them from the same NX_FLOAT concepts in the base class NXsample
  • add the (not recommended) possibility to write a float value in these environments if there are no actuators/sensors
  • allow multiple of pressure_gaugeID(NXsensor) on NXinstrument -> in preparation for a NXnapxps appdef
  • remove changes to final_polarization and incident_polarization from NXsample

@rettigl @domna this bundles all of the changes we were discussing in the last few days, also with respect to the requests from Stefan and Uwe. My plan is to first merge this and then rebase the mpes-liquid branch and finally make the necessary changes on NXmpes_liquid there.

@lukaspie lukaspie requested review from rettigl and domna July 9, 2024 11:58
@lukaspie lukaspie marked this pull request as ready for review July 9, 2024 11:58
Copy link

@domna domna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one small comment on the incident/final_polarization/@units. Otherwise LGTM

@lukaspie lukaspie merged commit 5ff3ed6 into fairmat Jul 11, 2024
6 checks passed
@lukaspie lukaspie deleted the mpes-clarifications branch July 11, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants