Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 2theta and use NXobject instead of collection. #272

Merged
merged 2 commits into from
Jul 22, 2024
Merged

fix 2theta and use NXobject instead of collection. #272

merged 2 commits into from
Jul 22, 2024

Conversation

RubelMozumder
Copy link

@RubelMozumder RubelMozumder commented Jul 19, 2024 •
edited
Loading

  1. A quick fix for NeXus incompatible concept name 2theta for XRD use case.
  2. Replace NXcollection for NXobject.

@RubelMozumder RubelMozumder requested a review from lukaspie July 19, 2024 15:23
lukaspie
lukaspie approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@lukaspie lukaspie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nyaml2nxdl consistency is failing, so please fix that. I only checked the nyaml file, lgtm.

@RubelMozumder RubelMozumder marked this pull request as ready for review July 22, 2024 10:09
@RubelMozumder RubelMozumder merged commit cb28e27 into fairmat Jul 22, 2024
6 checks passed
@RubelMozumder RubelMozumder deleted the XRD_2thta_fix branch July 22, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaspie lukaspie lukaspie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RubelMozumder @lukaspie