Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name type #53

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Name type #53

wants to merge 5 commits into from

Conversation

RubelMozumder
Copy link
Collaborator

@RubelMozumder RubelMozumder commented Feb 18, 2025

  • Update docs
  • Handle dimension that does not have any doc or dim. It should be and end leaf in yaml and nxdl.

@RubelMozumder
Copy link
Collaborator Author

RubelMozumder commented Feb 18, 2025

@lukaspie, the test should not be failed. I see this is weird. In my local setup, if I run the test separately it does not fail, but it fails when I run it all together.

@@ -65,6 +66,7 @@
"required",
"deprecated",
"units",
"nameType",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nameType is now twice in this tuple

def check_for_proper_nameType(name, nameType, error_location):
"""Check for proper nameType.

Name with all upper case letters should have nameType as `any` or `specific`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is specified, not specific!


Name with all upper case letters should have nameType as `any` or `specific`.
Name with all lower case letters should have nameType as `specific`.
Name with uper case or lower case letters should have nameType as `spcific` or `partial`.
Copy link
Collaborator

@lukaspie lukaspie Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle, you can put nameType=any also for all lower cases or partially variadic names. You shouldn't do this, but technically, nothing prevents me from writing fieldFIELD, nameType=any and then replacing that by some_other_name. Or even my_field, nameType=any and replacing that by yet_another_name.

nameType="any" really means any, including all lower case parts

Copy link
Collaborator

@mkuehbach mkuehbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parallel work to #58 and the issue43 with #47.
Rather we should test whether the examples that motivated this branch and PR here are not already handled by #58 with its respective feature branch.
This branch should be closed when #58 is merged into #47 and that in turn merged to master.

@lukaspie
Copy link
Collaborator

@RubelMozumder let's close this PR as this is now already handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants