-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name type #53
base: main
Are you sure you want to change the base?
Name type #53
Conversation
@lukaspie, the test should not be failed. I see this is weird. In my local setup, if I run the test separately it does not fail, but it fails when I run it all together. |
@@ -65,6 +66,7 @@ | |||
"required", | |||
"deprecated", | |||
"units", | |||
"nameType", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nameType is now twice in this tuple
def check_for_proper_nameType(name, nameType, error_location): | ||
"""Check for proper nameType. | ||
|
||
Name with all upper case letters should have nameType as `any` or `specific`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is specified, not specific!
|
||
Name with all upper case letters should have nameType as `any` or `specific`. | ||
Name with all lower case letters should have nameType as `specific`. | ||
Name with uper case or lower case letters should have nameType as `spcific` or `partial`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In principle, you can put nameType=any also for all lower cases or partially variadic names. You shouldn't do this, but technically, nothing prevents me from writing fieldFIELD, nameType=any
and then replacing that by some_other_name
. Or even my_field
, nameType=any and replacing that by yet_another_name
.
nameType="any"
really means any, including all lower case parts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RubelMozumder let's close this PR as this is now already handled. |
doc
ordim
. It should be and end leaf in yaml and nxdl.