Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: More coherent user errors #39

Closed
2 tasks done
FredHappyface opened this issue Feb 28, 2022 · 0 comments
Closed
2 tasks done

Feature: More coherent user errors #39

FredHappyface opened this issue Feb 28, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@FredHappyface
Copy link
Owner

Feature

  • I have read the comment above and have completed each step
  • I have filled in each heading below

Is your feature request related to a problem? Please describe

Error messages are pretty poor at the moment in the application. This issue is to track proposed changes at enhancing feedback to the end-user. This may help with some issues like #37. For example, one cause of the above issue may be that the user is meeting sticker import limits. At present the app does nothing to inform them of this

Describe the solution you'd like

Enhanced feedback through toast notifications to inform the user of

  • Sticker Pack size limits (present to reduce the number of crashes from giant sticker packs)
  • Total sticker limits (present to reduce number of crashes from selecting a root directory by accident)
  • Other sticker import issues (where the number of stickers differs from the number of files)
  • Other warnings/ errors not yet decided

Describe alternatives you've considered

Initial ideas:

Can probably create a class for this that triggers a toast notification and keeps an internal 'exit code' type state. Then can filter output. Eg.

  • Toaster.toast() to generate toast regardless.
  • Toaster.toasterror() to generate an error and set the error flag.
  • Toaster.toastiferror() to generate erro is error flag is set
  • Toaster.toastifsuccess() to generate success message (only if the error flag is unset)

Additional context

@FredHappyface FredHappyface added the enhancement New feature or request label Feb 28, 2022
@FredHappyface FredHappyface self-assigned this Feb 28, 2022
@FredHappyface FredHappyface added this to the Next_Ver 2022xxxx milestone Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant