-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/Change PHP.MigrationSet to update array/list syntax to short one #5428
Conversation
I understand "Migration" as a replacement of a deprecated concept by a new one. Short array syntax is just an alternative way to express your arrays. Just because someone prefers I feel the rule should stay out of a migration set and be kept as a style preference. |
When I created Migration rulesets, they were for purpose of "let use the new language/syntax/feature of higher version of PHP/PHPUnit". I agree one can say it's a matter of style. But one can also say that not using |
0ab0648
to
dc96a29
Compare
289884f
to
5711aed
Compare
5711aed
to
1f0c53b
Compare
Closes #5389 |
Rule set ``@PHP54Migration`` | ||
============================ | ||
|
||
Rules to improve code for PHP 5.6 compatibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PHP54Migration but then you say PHP 5.6, seems weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo, already fixed in other PR. thanks
No description provided.