Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have void items share items of the non-corrupted version's rarity on pickup. #160

Open
Nowea-Twitch opened this issue Mar 6, 2022 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@Nowea-Twitch
Copy link

Void item sharing would be in a strange gray area between normal items (pure benefit) and Lunars (benefit with downside within the item).

If void items are shared as random void items you are essentially handing out both potential downsides (example: crit build character getting Lost Seer's Lenses) and items of different base item rarity (example: you pick up Lost Seer's Lenses and your friend gets Benthic Bloom)

However... if you don't hand out anything when someone picks up a void item then the other players aren't getting any sort of power boost from the director credits used to spawn any form of void item. This could easily result in the snowballing that Sharesuite helps to prevent and bring vanilla-style item deliberations into the mod. This also encourages loot goblin behavior (especially from Void Friend)

It appears that void items still have the non-corrupted item's rarity under the hood (side note: this was just an observation based on BetterUI keeping void items grouped with the rarity of the non-corrupted item).

To address these issues in as elegant and smooth manner as possible, I'd propose simply handing each player an item of the same rarity of the non-corrupted item. This lets players continue more or less using the same strategic logic for item distribution as before and keeps the game flowing smoothly while (I imagine) being able to preserve the "host only" nature of the mod.

@Nowea-Twitch Nowea-Twitch added the enhancement New feature or request label Mar 6, 2022
@FunkFrog FunkFrog added this to the 3.0.0 milestone Mar 6, 2022
@FunkFrog
Copy link
Owner

FunkFrog commented Mar 6, 2022

Could also leverage #157 / #146 for better interoperability. Thanks!

@rehashedsalt
Copy link

I've no clue how feasible it is, but I feel like the ideal here would be to have the Void version of an item share its uncorrupted counterpart. Ex. when someone picks up Lost Seers, everybody else gets a copy of Lens Makers.

@Nowea-Twitch
Copy link
Author

I've no clue how feasible it is, but I feel like the ideal here would be to have the Void version of an item share its uncorrupted counterpart. Ex. when someone picks up Lost Seers, everybody else gets a copy of Lens Makers.

Yeah, when I wrote this up I had forgotten that the 'default' behavior is to not randomize the items. What you mention is how it'd probably work best when playing without randomized sharing. The only issue I'd see is how it'd handle items that have multiple uncorrupted items, like the Newly Hatched Zoea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

3 participants