Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #5137][Fixes #5138] Encode Hierarchical tags and external service #5142

Merged
merged 5 commits into from
Oct 29, 2019

Conversation

t-book
Copy link
Contributor

@t-book t-book commented Oct 29, 2019

[Fixes #5137]
[Fixes #5138]

Encode Hierarchical tags and external service

Checklist

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemptions is, changes not visible to end users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there are explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@t-book t-book requested a review from capooti October 29, 2019 13:58
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Oct 29, 2019
@t-book
Copy link
Contributor Author

t-book commented Oct 29, 2019

@afabiani 😂faster than light, while I'm still reading if everything is correct you already set the labels. Thanks!

Copy link
Member

@capooti capooti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @t-book! +1 to merge it once Travis is done

@t-book
Copy link
Contributor Author

t-book commented Oct 29, 2019

thanks a lot @capooti !

@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #5142 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5142      +/-   ##
==========================================
+ Coverage   53.68%   53.68%   +<.01%     
==========================================
  Files         185      185              
  Lines       20806    20808       +2     
  Branches     3309     3309              
==========================================
+ Hits        11169    11171       +2     
  Misses       8628     8628              
  Partials     1009     1009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escape Hierarchical-tags Striptags for service resources
3 participants