Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6156 Fixes #6180 RTL template #6183

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Fixes #6156 Fixes #6180 RTL template #6183

merged 1 commit into from
Jun 11, 2020

Conversation

t-book
Copy link
Contributor

@t-book t-book commented Jun 10, 2020

This adds the RTL Feature as described at #6182.

  • A new less file has been added to keep things tidy.
  • The map viewer(s) and metadata Wizard has been kept LTR as there js does set animation directions

I'm adding some impressions here: https://www.dropbox.com/sh/m6w7b58a99tl993/AABPAGYFc5l8ILEHMaO_eZHda?dl=0

The arabic translation needs further work. Hopefully to come.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jun 10, 2020
@afabiani afabiani added this to the 3.1 milestone Jun 10, 2020
@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #6183 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6183   +/-   ##
=======================================
  Coverage   59.45%   59.45%           
=======================================
  Files         181      181           
  Lines       20176    20176           
  Branches     3341     3341           
=======================================
  Hits        11995    11995           
  Misses       7124     7124           
  Partials     1057     1057           

@afabiani afabiani merged commit 1703c61 into GeoNode:master Jun 11, 2020
afabiani pushed a commit that referenced this pull request Jun 11, 2020
(cherry picked from commit 1703c61)
@t-book t-book changed the title Fixes #6182 Fixes #6180 RTL template Fixes #6156 Fixes #6180 RTL template Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants