fix: animation start event breaking ui responsiveness #2941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size
|
oliverlaz
approved these changes
Feb 11, 2025
khushal87
approved these changes
Feb 11, 2025
|
🎉 This PR is included in version 6.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Should fix this Github issue.
The TL;DR is that the gesture was getting rid of its own activation criteria and relying on manual activation. In these cases, if the gesture is indeed recognized (for example from a long press) but the state is not managed manually it will not know how to recover properly (for example
state.fail()if it's not the correct gesture).As there isn't enough time for the gesture to actually fail before the bottom sheet pops up, the entire handling was caught in a weird state.
🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch