Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rubocop): ENV.fetch('xy') instead of ENV['xy'] per rubocop #140

Merged
merged 1 commit into from
May 30, 2022

Conversation

peterdeme
Copy link
Contributor

@peterdeme peterdeme commented May 27, 2022

Plus fix rubocop error

@peterdeme peterdeme requested a review from ferhatelmas as a code owner May 27, 2022 12:29
@peterdeme peterdeme force-pushed the peterdeme-patch-1 branch 2 times, most recently from 6a2db4b to 5ef3bce Compare May 27, 2022 12:42
@peterdeme peterdeme force-pushed the peterdeme-patch-1 branch 4 times, most recently from db2e5ff to 5823371 Compare May 27, 2022 12:50
@peterdeme peterdeme changed the title docs: update readme fix(rubocop): ENV.fetch('xy') instead of ENV['xy'] per rubocop May 27, 2022
@ferhatelmas
Copy link
Contributor

@peterdeme still failing

@peterdeme peterdeme force-pushed the peterdeme-patch-1 branch from 5823371 to 0c0e9ef Compare May 30, 2022 09:12
@peterdeme
Copy link
Contributor Author

@ferhatelmas fixed

@ferhatelmas ferhatelmas merged commit 6b25736 into main May 30, 2022
@ferhatelmas ferhatelmas deleted the peterdeme-patch-1 branch May 30, 2022 12:16
@github-actions github-actions bot mentioned this pull request Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants