feat: support static token and token provider at the same time #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-native-builder-bob and a few more deps
oliverlaz
requested review from
myandrienko,
santhoshvai,
kristian-mkd and
szuperaz
santhoshvai
approved these changes
Feb 14, 2025
myandrienko
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Until now, providing both,
tokenandtokenProviderwasn't truly supported, and when this was the case, theclientalways used thestatictoken.This PR allows the client to connect faster and save one roundtrip to the customer's servers.
The logic is the following:
tokenis provided - use thetoken(existing behavior)tokenProvideris provided - use thetokenProvider(existing behavior)tokenandtokenProviderare provided - use thetokeninitially. Once it expires, use thetokenProvider(new behavior).The new behavior aligns with the logic that the other SDKs have, and it potentially reduces the time it takes to establish a WS connection to our systems.
In addition, we now validate internally that the token provided by the token provider is issued for the correct
user_id.This should prevent potential integration issues.This PR also refactors and cleans the code used to construct a new
StreamVideoClientand also adds test cases for the critical parts of it.Also, a few dependencies are updated to their latest versions (
axios,sdp-transform,ua-parser-js,vitest, etc...).