Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't implicitly mark calls as ringing #1697

Merged
merged 2 commits into from
Feb 26, 2025
Merged

fix: don't implicitly mark calls as ringing #1697

merged 2 commits into from
Feb 26, 2025

Conversation

oliverlaz
Copy link
Member

Overview

Fixes an issue where reused ringing call instances were implicitly marked as ringing.
For example:

await call.get({ ring: true });
await call.leave();

// This is used to mark the `call` instance as `ringing` 
// and set the `callingState` to `RINGING`
await call.get();

Implementation notes

We don't consider the (past) internal state of the call instance when it is reinitialized. This aligns the behavior with the rest of the SDKs.

Fixes: #1561 (comment)

@oliverlaz oliverlaz merged commit 3429a7b into main Feb 26, 2025
19 checks passed
@oliverlaz oliverlaz deleted the ring-state branch February 26, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Session participants are not updated after the call ends
3 participants