updated pty.cpp to the new Nan 2.0.0 signatures #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Gottox,
I ran a script that updates the signatures inside pty.cpp to work with nan 2.0.9;
Let me just make clear that the last time i typed any cpp was 15 years ago and im not sure in the quality of my conversion.
either way the tests pass and i hope you will find this contribution useful.
a warning; there are 3 symbols that the compiler couldn't find so i commented them out: IUCLC, OLCLC and XCASE
Also i switched the signature of the o->Set method to use v8::Number instead of Integer as integer couldn't be resolved to the correct header method (maybe this opens a buffer overflow vulnerability)
Thanks,
Petar