Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated pty.cpp to the new Nan 2.0.0 signatures #8

Merged
merged 1 commit into from
Sep 9, 2015

Conversation

vlahupetar
Copy link
Contributor

Hi Gottox,
I ran a script that updates the signatures inside pty.cpp to work with nan 2.0.9;
Let me just make clear that the last time i typed any cpp was 15 years ago and im not sure in the quality of my conversion.
either way the tests pass and i hope you will find this contribution useful.

a warning; there are 3 symbols that the compiler couldn't find so i commented them out: IUCLC, OLCLC and XCASE

Also i switched the signature of the o->Set method to use v8::Number instead of Integer as integer couldn't be resolved to the correct header method (maybe this opens a buffer overflow vulnerability)

Thanks,
Petar

@Gottox
Copy link
Owner

Gottox commented Sep 9, 2015

Nice, that's a good starting point. Unfortunartely this PR breaks older node.js versions, but I'm working on a fix.

Thanks :)

@Gottox Gottox merged commit 559dd7f into Gottox:master Sep 9, 2015
@Gottox Gottox mentioned this pull request Sep 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants