Addon json config changes are not honored

[nyxkn]

Editing the addon config json from Anki GUI does not work as intended (Tools -> Addons -> Config).

At a quick glance this might be because we're manually loading the config.json in ConfigManager, and manually saving to config_saved.json. But all of this bypasses the standard Anki behaviour of reading config files (https://github.com/ankitects/anki/blob/69ac450098518a39a1d955102a33c927281447d9/qt/aqt/addons.py#L706), where getConfig reads config.json but supplements it with meta.json, which is automatically updated when the user modifies the addon config from the GUI.

Maybe also related to #73

[kieranlblack]

Apologies for the delayed response to this. Nice sleuthing work, I think your analysis of the issue is correct. Interestingly this looks intentional but there isn't much context as to why. See this commit jdlorimer/chinese-support-redux@a9dcaef

Since it looks like the original maintainers were trying to force people to redo their settings each time the addon upgraded, my guess is this was an attempt at allowing the maintainers at the time a way to make backwards-incompatible changes to the settings across versions of the addon without getting any weird behaviour.

Do you have any interest in fixing this? I would be happy to review a PR if you open one.

[nyxkn]

My idea would be to remove the code for custom config management and revert to standard anki behaviour. If that sounds acceptable then I'm happy to have a stab.

[kieranlblack]

Sounds good, I think that is the right call here. Thank you for looking into it.