Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librsvg 2.52.3 #85278

Closed
wants to merge 3 commits into from
Closed

librsvg 2.52.3 #85278

wants to merge 3 commits into from

Conversation

tschoonj
Copy link
Contributor

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` rust Rust use is a significant feature of the PR or issue labels Sep 16, 2021
@tschoonj
Copy link
Contributor Author

See https://gitlab.gnome.org/GNOME/librsvg/-/issues/787

The build goes without a hitch on my Intel MacBook Pro running 11.6

@chenrui333 chenrui333 added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Sep 18, 2021
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Sep 22, 2021
@github-actions github-actions bot closed this Sep 23, 2021
@chenrui333 chenrui333 reopened this Sep 25, 2021
@chenrui333 chenrui333 removed the stale No recent activity label Sep 25, 2021
@chenrui333 chenrui333 added CI-requeued PR has been re-added to the queue build failure CI fails while building the software labels Sep 25, 2021
@chenrui333
Copy link
Member

chenrui333 commented Sep 27, 2021 •
edited
Loading 

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/nm: error:
./.libs/librsvg_c_api.a(std-fe51b9edd1d1eaed.std.99f315dd-cgu.0.rcgu.o) Unknown attribute kind (96) 
(Producer: 'LLVM12.0.1-rust-1.55.0-stable' Reader: 'LLVM APPLE_1_1205.0.22.9_0')

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/nm: error: 
./.libs/librsvg_c_api.a(std-fe51b9edd1d1eaed.std.99f315dd-cgu.10.rcgu.o) Unknown attribute kind (128) 
(Producer: 'LLVM12.0.1-rust-1.55.0-stable' Reader: 'LLVM APPLE_1_1205.0.22.9_0')

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/nm: error: 
./.libs/librsvg_c_api.a(std-fe51b9edd1d1eaed.std.99f315dd-cgu.11.rcgu.o) Unknown attribute kind (216) 
(Producer: 'LLVM12.0.1-rust-1.55.0-stable' Reader: 'LLVM APPLE_1_1205.0.22.9_0')
...

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Sep 30, 2021
@SMillerDev
Copy link
Member

Rebased, I'm hoping the Xcode update fixed something.

@github-actions github-actions bot removed the stale No recent activity label Sep 30, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Oct 3, 2021
@carlocab carlocab added help wanted Task(s) needing PRs from the community or maintainers 11-arm64 Big Sur arm64 is specifically affected and removed stale No recent activity labels Oct 3, 2021
@tschoonj tschoonj force-pushed the bump-librsvg-2.52.0 branch from 937606f to 623ec3c Compare October 17, 2021 12:18
@SMillerDev
Copy link
Member

It fails to build on ARM:

 cd /private/tmp/librsvg-20211017-63308-xtpjk9/librsvg-2.52.2 && mv /private/tmp/librsvg-20211017-63308-xtpjk9/librsvg-2.52.2/target/release/rsvg-convert rsvg-convert
    Finished release [optimized] target(s) in 1m 03s
warning: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: archive library: .libs/librsvg_c_api.a the table of contents is empty (no object file members in the library define global symbols)
  CCLD     librsvg-2.la
./.libs/librsvg_c_api.a:addr2line-4174108a800ed70c.addr2line.f0613d02-cgu.5.rcgu.o: no symbols
./.libs/librsvg_c_api.a:rustc_std_workspace_alloc-39a37ce3deee7fd0.rustc_std_workspace_alloc.a091e09a-cgu.0.rcgu.o: no symbols
./.libs/librsvg_c_api.a:cfg_if-263742f878cd5cbc.cfg_if.acef5b15-cgu.0.rcgu.o: no symbols
./.libs/librsvg_c_api.a:rustc_std_workspace_core-347f56b9a3cedfe8.rustc_std_workspace_core.c840dad3-cgu.0.rcgu.o: no symbols
libtool:   error: object name conflicts in archive: .libs/librsvg-2.lax/librsvg_c_api.a//private/tmp/librsvg-20211017-63308-xtpjk9/librsvg-2.52.2/./.libs/librsvg_c_api.a
make[2]: *** [librsvg-2.la] Error 1
make[1]: *** [install-recursive] Error 1
make: *** [install] Error 2

and does this error on 11 mean that we need to rebuild gdx-pixbuff?

 ==> /usr/local/Cellar/cherrytree/0.99.42/bin/cherrytree /private/tmp/cherrytree-test-20211017-77378-9h4xwa/homebrew.ctd --export_to_txt_dir /private/tmp/cherrytree-test-20211017-77378-9h4xwa --export_single_file
Warning: 17 14:02:38.847] [   ] [warning] /private/tmp/cherrytree-test-20211017-77378-9h4xwa/.config/cherrytree/config.cfg missing
[2021-10-17 14:02:38.850] [   ] [debug] export arguments are detected
[2021-10-17 14:02:38.850] [   ] [debug] file to export: /private/tmp/cherrytree-test-20211017-77378-9h4xwa/homebrew.ctd

(<unknown>:77392): Gtk-WARNING **: 14:02:39.536: Found an icon but could not load it. Most likely gdk-pixbuf does not provide SVG support.

@EricFromCanada EricFromCanada changed the title librsvg 2.52.0 librsvg 2.52.2 Oct 18, 2021
@chenrui333 chenrui333 mentioned this pull request Oct 27, 2021
Closed
@carlocab
Copy link
Member

carlocab commented Nov 7, 2021 •
edited
Loading

There's an open upstream issue: https://gitlab.gnome.org/GNOME/librsvg/-/issues/787 (Edit: oops, already referenced above.)

It also affects the ARM build for the current version of librsvg. The issue suggests this has to do with the version of Rust we're using.

@SMillerDev SMillerDev changed the title librsvg 2.52.2 librsvg 2.52.3 Nov 9, 2021
@carlocab
Copy link
Member

carlocab commented Nov 9, 2021

This will probably still fail with any Rust version newer than 1.52.2.

@Subsentient
Copy link

It has been suggested that this can be fixed by setting Rust's build-std option. Can anyone test to see if that fixes it? Seems homebrew eats all my environment variables.

@fxcoudert
Copy link
Member

It has been suggested that this can be fixed by setting Rust's build-std option

Can you have a more specific information, or provide a link? I've investigated the issue a bit further (see my comments on https://gitlab.gnome.org/GNOME/librsvg/-/issues/787), found that it's a rust runtime object file included too many times in a static archive.

@fxcoudert
Copy link
Member

Thinking it may be a rust issue, filed at rust-lang/compiler-builtins#443

@SMillerDev
Copy link
Member

Thanks @fxcoudert for digging into that

@carlocab
Copy link
Member

One thing worth noting is that MacPorts are able to build librsvg just fine with their Rust: https://ports.macports.org/port/librsvg/details/

So I wonder if the bug is somewhere on our side.

@fxcoudert
Copy link
Member

Following my report upstream, here is a compiler-builtins PR that should fix the issue: rust-lang/compiler-builtins#444

We could try to add that patch to rust, and recompile librsvg with it, see if that works.

@carlocab carlocab mentioned this pull request Nov 28, 2021
Closed
@carlocab
Copy link
Member

#90103

Not sure if we want to put librsvg along with that PR (or include that change here). Feel free to amend my PR as needed.

@carlocab carlocab removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Dec 8, 2021
branchvincent pushed a commit to carlocab/homebrew-core that referenced this pull request Dec 30, 2021
@carlocab @branchvincent
rust: apply patch to fix duplicate object file bug
7435208 
Having multiple object files with the same name upsets libtool and
breaks the librsvg build. See Homebrew#85278.
BrewTestBot pushed a commit that referenced this pull request Jan 2, 2022
@carlocab @BrewTestBot
rust: apply patch to fix duplicate object file bug
9839482 
Having multiple object files with the same name upsets libtool and
breaks the librsvg build. See #85278.
@carlocab carlocab force-pushed the bump-librsvg-2.52.0 branch from 1f8663b to 06a76d8 Compare January 2, 2022 13:03
@carlocab
Copy link
Member

carlocab commented Jan 2, 2022

On Monterey ARM:

  libtool:   error: object name conflicts in archive: .libs/librsvg-2.lax/librsvg_c_api.a//private/tmp/librsvg-20220102-94168-h8oovk/librsvg-2.52.3/./.libs/librsvg_c_api.a

@iMichka iMichka added the long build Set a long timeout for formula testing label Jan 17, 2022
@carlocab carlocab added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 18, 2022
@carlocab carlocab force-pushed the bump-librsvg-2.52.0 branch from 06a76d8 to 2bb060c Compare January 18, 2022 03:57
@carlocab carlocab removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jan 18, 2022
carlocab
carlocab approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All ✅ 🎉

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Feb 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
11-arm64 Big Sur arm64 is specifically affected build failure CI fails while building the software bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-requeued PR has been re-added to the queue help wanted Task(s) needing PRs from the community or maintainers long build Set a long timeout for formula testing outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tschoonj @chenrui333 @SMillerDev @carlocab @Subsentient @fxcoudert @BrewTestBot @iMichka