-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
icu4c 70.1 #88210
icu4c 70.1 #88210
Conversation
Linkage failures on ARM:
There's plenty more on Linux. |
Linux linkage failures are awkward as they are checked recursively, which I'll try fix first before pushing.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
Plan for this is to do it after |
OpenLDAP is finally merged, shall I rebase this? |
a5530a7
to
96e3906
Compare
You still have a conflict for |
Oh libsoup just got merged when I was rebasing it seems. |
96e3906
to
f9949f0
Compare
Are any of these GCC dependents? If they are we may want to rebase this so we can attempt a bottle build when applicable. |
I've maybe missed others but that's what I see from a very quick glance through what has a |
Only ones that show up for me (on Probably only |
I've got PRs open for most failures (last couple will be up in a bit). I do not think it will be possible to revision bump |
@danielnachun I think we'll have to reduce the size of the installed packages for texlive. Is this something you could pick up? |
Definitely. The reason the bottle is so big right now is because of the |
Since we doubled space of self-hosted Linux to 100G due to |
I think we were running out of space on macOS actually, though we should confirm that. |
Ah. I do see Intel macOS is out of space now. Only checked Linux and ARM macOS. |
Still can't find |
Until ephemeral, I'll cover this scenario with Homebrew/actions#262 (and I'll set
Hopefully fixed by Homebrew/brew#12947 |
Let's run #96101 ASAP when this is merged, even if it entails premature removal of a |
|
|
That error basically means "gpg didn't exit successfully", which is always fun to debug as it means absolutely anything and it's not reproducible in a local Docker container. |
Oh of course, it'll be because brew env filters GNUPGHOME. |
|
|
😭 |
I suggest a manual merge while dropping |
Attempting a manual merge. Downloading the bottles now. Will warn before I start an upload attempt. |
I decided to leave the download going overnight. It's finished now, but I'll be on the road so will try an upload when I have a stable connection. |
Attempting upload. |
Merge conflict for |
Closes Homebrew#88210. Signed-off-by: Carlo Cabrera <[email protected]>
We need a better way to "lock" formula or whatever. A significant amount of the pain here is because of conflicts. ICU 71 will probably be out next month, and I'm up for coordinating the revision bumps for that again, but I just can't monitor every single PR which comes in while the build is happening. |
Maybe CODEOWNERS is the solution here. |
Agreed. I tried to monitor PRs too, but I can't watch this repo 24/7 and
This sounds like a good idea, actually. Is there a way to make code owner review mandatory only for specific files? |
In terms of GitHub branch protection? No, but we could make |
Or actually it maybe doesn't even need to be that complicated - it probably only needs to be on autopublish level |
If we could automatically label those PRs with The labelling has the bonus of already blocking autopublish. |
Makes sense. I would maybe lean on a separate red label just to make it more obvious to the PR author what's going on rather than getting a random "do not merge" label immediately. |
Sure, I'm fine with that too. |
Created with
brew bump-formula-pr
.Not yet officially announced yet, but it will be by the time we're ready with this.