Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjdk: bump revision for gcc, fixes RPATH issue #89642

Closed
wants to merge 1 commit into from

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Nov 18, 2021

Fixes java.lang.UnsatisfiedLinkError
See #84886

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@iMichka iMichka added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 18, 2021
@BrewTestBot BrewTestBot added the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Nov 18, 2021
@iMichka
Copy link
Member Author

iMichka commented Nov 18, 2021

49 failed in Linux, mostly due to:
/home/linuxbrew/.linuxbrew/opt/openjdk/libexec/openjdk.jdk/Contents/Home/bin/java: No such file or directory
/home/linuxbrew/.linuxbrew/opt/openjdk@8/libexec/openjdk.jdk/Contents/Home/bin/java: No such file or directory

@iMichka iMichka added the CI-linux-self-hosted Build on Linux self-hosted runner label Nov 18, 2021
@BrewTestBot BrewTestBot added the java Java use is a significant feature of the PR or issue label Nov 18, 2021
@Bo98
Copy link
Member

Bo98 commented Nov 18, 2021

49 failed in Linux, mostly due to: /home/linuxbrew/.linuxbrew/opt/openjdk/libexec/openjdk.jdk/Contents/Home/bin/java: No such file or directory /home/linuxbrew/.linuxbrew/opt/openjdk@8/libexec/openjdk.jdk/Contents/Home/bin/java: No such file or directory

Looks like these are :all bottles without Linux support (i.e. before Java relocation support was added).

@danielnachun
Copy link
Contributor

Should we rerun this with CI-no-fail-fast? There's some universal binary audit failures that should eventually be fixed but could be ignored or added to the allowlist.

@iMichka iMichka added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Nov 21, 2021
@iMichka
Copy link
Member Author

iMichka commented Nov 21, 2021

Yes, I'm going to have a full run here, I think most errors are unrelated and we can ship this. We can start working on the issues later.

@iMichka
Copy link
Member Author

iMichka commented Nov 25, 2021

Some fixes:
#89980
#89695
#89976

@iMichka iMichka mentioned this pull request Nov 26, 2021
6 tasks
@BrewTestBot BrewTestBot removed the java Java use is a significant feature of the PR or issue label Nov 27, 2021
@iMichka
Copy link
Member Author

iMichka commented Nov 29, 2021

Rebuilding after the last run. The revision bumps are needed to fix (mostly) the following errors:
/home/linuxbrew/.linuxbrew/opt/openjdk/libexec/openjdk.jdk/Contents/Home/bin/java: No such file or directory

Fixes java.lang.UnsatisfiedLinkError
See Homebrew#84886
@iMichka
Copy link
Member Author

iMichka commented Dec 1, 2021

@carlocab @Bo98 let's ship this, the bottles have been built and uploaded. The other errors are unrelated, I already fixed a few, but I do not want to hold off this one for way longer.

@carlocab
Copy link
Member

carlocab commented Dec 1, 2021

Which failures (i.e. warnings, not errors) are left unaddressed?

@iMichka
Copy link
Member Author

iMichka commented Dec 1, 2021

Here is the full list:

12-ARM
Warning: 23 failed steps ignored!
brew install --build-from-source anjuta
brew test --retry --verbose astrometry-net dstndstn/astrometry.net#241
brew test --retry --verbose beast
brew install --build-from-source bigloo
brew install --build-from-source dynare
brew install --build-from-source ford
brew install --build-from-source gegl
brew linkage --cached --test --strict karchive
brew install --build-from-source kotlin-language-server
brew install --build-from-source languagetool
brew install --build-from-source libgdata
brew test --retry --verbose libgdata
brew linkage --cached --test --strict link-grammar
brew linkage --cached --test --strict man-db
brew install --build-from-source mercury
brew linkage --cached --test --strict nco
brew install --build-from-source opensearch
brew install --build-from-source pdfpc
brew test --retry --verbose pympress
brew linkage --cached --test --strict root
brew test --retry --verbose root
brew install --build-from-source swagger-codegen
brew install --build-from-source upscaledb
Error: 2 failed steps!
brew fetch --build-from-source --retry acme
brew fetch --build-from-source --retry apache-ctakes #9016

12-ARM
Warning: 12 failed steps ignored!
brew install --build-from-source anjuta
brew test --retry --verbose astrometry-net dstndstn/astrometry.net#241
brew install --build-from-source ford
brew linkage --cached --test --strict karchive
brew install --build-from-source libgdata
brew test --retry --verbose libgdata
brew linkage --cached --test --strict link-grammar
brew linkage --cached --test --strict man-db
brew linkage --cached --test --strict nco
brew test --retry --verbose opensearch
brew linkage --cached --test --strict root
brew linkage --cached --test --strict upscaledb
Error: 4 failed steps!
brew fetch --build-from-source --retry acme
brew fetch --build-from-source --retry apache-ctakes #9016
brew install --build-from-source gegl

11-ARM
Warning: 14 failed steps ignored!
brew test --retry --verbose astrometry-net dstndstn/astrometry.net#241
brew test --retry --verbose beast
brew install --build-from-source bigloo
brew install --build-from-source dynare
brew linkage --cached --test --strict karchive
brew install --build-from-source languagetool
brew linkage --cached --test --strict link-grammar
brew linkage --cached --test --strict man-db
brew install --build-from-source mercury
brew linkage --cached --test --strict nco
brew install --build-from-source opensearch
brew install --build-from-source pdfpc
brew test --retry --verbose pympress
brew install --build-from-source upscaledb
Error: 5 failed steps!
brew fetch --build-from-source --retry acme
brew fetch --build-from-source --retry apache-ctakes #9016
brew install --build-from-source ford
brew install --build-from-source kotlin-language-server
brew install --build-from-source root

11
Warning: 6 failed steps ignored!
brew test --retry --verbose astrometry-net dstndstn/astrometry.net#241
brew linkage --cached --test --strict karchive
brew linkage --cached --test --strict link-grammar
brew linkage --cached --test --strict man-db
brew linkage --cached --test --strict nco
brew linkage --cached --test --strict upscaledb
Error: 6 failed steps!
brew fetch --build-from-source --retry acme
brew fetch --build-from-source --retry apache-ctakes #9016
brew test --retry --verbose dynare
brew test --retry --verbose dynare
brew install --build-from-source ford
brew install --build-from-source root

Linux
Warning: 2 failed steps ignored!
brew linkage --cached --test --strict emscripten
brew linkage --cached --test --strict semgrep #90199
Error: 15 failed steps!
brew install apache-archiva #89695
brew test --retry --verbose batik #90145
brew linkage --test civl #89980
brew test --retry --verbose civl #89980
brew test --retry --verbose davmail #90152
brew test --retry --verbose druid #90196
brew test --retry --verbose ec2-ami-tools #90146
brew test --retry --verbose jolie
brew test --retry --verbose launch4j #89976
brew test --retry --verbose mrbayes #90197
brew test --retry --verbose mx #90198
brew test --retry --verbose parquet-cli
brew test --retry --verbose sbuild #90149
brew test --retry --verbose storm #90151
brew linkage --test wildfly-as #90148

@carlocab
Copy link
Member

carlocab commented Dec 1, 2021

Those are actually mostly warnings (except on Linux). The errors are:

12-arm64

Error: 2 failed steps!
brew fetch --build-from-source --retry acme
brew fetch --build-from-source --retry apache-ctakes

12

Error: 4 failed steps!
brew fetch --build-from-source --retry acme
brew fetch --build-from-source --retry apache-ctakes
brew install --build-from-source gegl
rm -rf /Users/brew/Library/Caches/Homebrew

11-arm64

Error: 5 failed steps!
brew fetch --build-from-source --retry acme
brew fetch --build-from-source --retry apache-ctakes
brew install --build-from-source ford
brew install --build-from-source kotlin-language-server
brew install --build-from-source root

11

Error: 6 failed steps!
brew fetch --build-from-source --retry acme
brew fetch --build-from-source --retry apache-ctakes
brew test --retry --verbose dynare
brew test --retry --verbose dynare
brew install --build-from-source ford
brew install --build-from-source root

10.15

Error: 4 failed steps!
brew fetch --build-from-source --retry acme
brew fetch --build-from-source --retry apache-ctakes
brew install --build-from-source ford
brew test --retry --verbose jython

Linux

Error: 15 failed steps!
brew install apache-archiva
brew test --retry --verbose batik
brew linkage --test civl
brew test --retry --verbose civl
brew test --retry --verbose davmail
brew test --retry --verbose druid
brew test --retry --verbose ec2-ami-tools
brew test --retry --verbose jolie
brew test --retry --verbose launch4j
brew test --retry --verbose mrbayes
brew test --retry --verbose mx
brew test --retry --verbose parquet-cli
brew test --retry --verbose sbuild
brew test --retry --verbose storm
brew linkage --test wildfly-as

We should check out what happened to ford and maybe root as that seems to occur on multiple runners.

@iMichka
Copy link
Member Author

iMichka commented Dec 1, 2021

I have a fix for ford here #90218

@BrewTestBot
Copy link
Member

:shipit: @iMichka has triggered a merge.

@iMichka iMichka deleted the openjdk2 branch December 1, 2021 18:46
@BrewTestBot
Copy link
Member

@carlocab bottle request for vice failed.

@carlocab
Copy link
Member

carlocab commented Dec 3, 2021

New bottle committed at #90322.

@github-actions github-actions bot added the outdated PR was locked due to age label Jan 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-linux-self-hosted Build on Linux self-hosted runner CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants