-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apache-archiva: fix non-native binaries #89695
Conversation
We can probably build those wrappers from source. See #88380. |
Note for myself: I'll have a look if I can build this from source ... |
aa58891
to
50cb831
Compare
50cb831
to
a9e1605
Compare
a9e1605
to
c904a41
Compare
4cf41fb
to
c71a30c
Compare
The "drawback" is as this needs openjdk 8, we sort of "loose" the ARM build. On the other hand this was an |
It's probably worth noting here that Azul now ships an OpenJDK8 ARM build: https://cdn.azul.com/zulu/bin/zulu8.58.0.13-ca-jdk8.0.312-macosx_aarch64.tar.gz. I also opened a PR to try to fix OpenJDK8 on Intel Monterey: #89982. I'll try to force an ARM build on this if it works with Intel. |
c71a30c
to
efc3c35
Compare
I also added |
Maybe this can wait until #90008 is merged. |
04d349c
to
19440d1
Compare
This just ships a bunch of pre-compiled binaries and is not built from source. This was already known in Homebrew#12427 (comment) Fixes: * Binaries built for a non-native architecture were installed into apache-archiva's prefix. The offending files are: /opt/homebrew/Cellar/apache-archiva/2.2.5_1/libexec/bin/wrapper-macosx-universal-32 (universal) /opt/homebrew/Cellar/apache-archiva/2.2.5_1/libexec/bin/wrapper-macosx-universal-64 (universal) /opt/homebrew/Cellar/apache-archiva/2.2.5_1/libexec/lib/libwrapper-macosx-universal-32.jnilib (universal) /opt/homebrew/Cellar/apache-archiva/2.2.5_1/libexec/lib/libwrapper-macosx-universal-64.jnilib (universal)
19440d1
to
aca82a9
Compare
aca82a9
to
8ae0d08
Compare
8ae0d08
to
2864abb
Compare
2864abb
to
0cc23fa
Compare
This just ships a bunch of pre-compiled binaries and is not built from source.
This was already known in #12427 (comment)
Fixes:
* Binaries built for a non-native architecture were installed into apache-archiva's prefix.
The offending files are:
/opt/homebrew/Cellar/apache-archiva/2.2.5_1/libexec/bin/wrapper-macosx-universal-32 (universal)
/opt/homebrew/Cellar/apache-archiva/2.2.5_1/libexec/bin/wrapper-macosx-universal-64 (universal)
/opt/homebrew/Cellar/apache-archiva/2.2.5_1/libexec/lib/libwrapper-macosx-universal-32.jnilib (universal)
/opt/homebrew/Cellar/apache-archiva/2.2.5_1/libexec/lib/libwrapper-macosx-universal-64.jnilib (universal)
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?