Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apache-archiva: fix non-native binaries #89695

Closed
wants to merge 2 commits into from

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Nov 19, 2021

This just ships a bunch of pre-compiled binaries and is not built from source.
This was already known in #12427 (comment)

Fixes:
* Binaries built for a non-native architecture were installed into apache-archiva's prefix.
The offending files are:
/opt/homebrew/Cellar/apache-archiva/2.2.5_1/libexec/bin/wrapper-macosx-universal-32 (universal)
/opt/homebrew/Cellar/apache-archiva/2.2.5_1/libexec/bin/wrapper-macosx-universal-64 (universal)
/opt/homebrew/Cellar/apache-archiva/2.2.5_1/libexec/lib/libwrapper-macosx-universal-32.jnilib (universal)
/opt/homebrew/Cellar/apache-archiva/2.2.5_1/libexec/lib/libwrapper-macosx-universal-64.jnilib (universal)

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added formula disabled Formula disabled java Java use is a significant feature of the PR or issue labels Nov 19, 2021
@carlocab
Copy link
Member

We can probably build those wrappers from source. See #88380.

@iMichka
Copy link
Member Author

iMichka commented Nov 21, 2021

Note for myself:
Commercial website / license pages: https://wrapper.tanukisoftware.com/doc/english/licenseOverview.html
Source code can be found here: https://sourceforge.net/p/wrapper/code/2064/tree/trunk/wrapper/

I'll have a look if I can build this from source ...

@BrewTestBot BrewTestBot removed the formula disabled Formula disabled label Nov 25, 2021
@BrewTestBot BrewTestBot added the deprecated license Formula uses a deprecated SPDX license which should be updated label Nov 25, 2021
@BrewTestBot BrewTestBot removed the deprecated license Formula uses a deprecated SPDX license which should be updated label Nov 25, 2021
@iMichka iMichka changed the title apache-archiva: disable apache-archiva: fix non-native binaries Nov 25, 2021
@iMichka iMichka force-pushed the apache-archiva branch 5 times, most recently from 4cf41fb to c71a30c Compare November 25, 2021 22:03
@iMichka iMichka requested a review from carlocab November 25, 2021 22:33
@iMichka
Copy link
Member Author

iMichka commented Nov 25, 2021

The "drawback" is as this needs openjdk 8, we sort of "loose" the ARM build. On the other hand this was an all bottle, so who knows if it was working properly.

@danielnachun
Copy link
Contributor

It's probably worth noting here that Azul now ships an OpenJDK8 ARM build: https://cdn.azul.com/zulu/bin/zulu8.58.0.13-ca-jdk8.0.312-macosx_aarch64.tar.gz. I also opened a PR to try to fix OpenJDK8 on Intel Monterey: #89982. I'll try to force an ARM build on this if it works with Intel.

@iMichka
Copy link
Member Author

iMichka commented Nov 26, 2021

I also added depends_on arch: :x86_64 # openjdk@8 doesn't support ARM as for other formulae.

@iMichka iMichka requested a review from carlocab November 26, 2021 06:18
@carlocab
Copy link
Member

Maybe this can wait until #90008 is merged.

@iMichka iMichka force-pushed the apache-archiva branch 2 times, most recently from 04d349c to 19440d1 Compare November 26, 2021 18:11
This just ships a bunch of pre-compiled binaries and is not built from source.
This was already known in Homebrew#12427 (comment)

Fixes:
    * Binaries built for a non-native architecture were installed into apache-archiva's prefix.
      The offending files are:
        /opt/homebrew/Cellar/apache-archiva/2.2.5_1/libexec/bin/wrapper-macosx-universal-32	(universal)
        /opt/homebrew/Cellar/apache-archiva/2.2.5_1/libexec/bin/wrapper-macosx-universal-64	(universal)
        /opt/homebrew/Cellar/apache-archiva/2.2.5_1/libexec/lib/libwrapper-macosx-universal-32.jnilib	(universal)
        /opt/homebrew/Cellar/apache-archiva/2.2.5_1/libexec/lib/libwrapper-macosx-universal-64.jnilib	(universal)
@BrewTestBot
Copy link
Member

:shipit: @iMichka has triggered a merge.

@iMichka iMichka deleted the apache-archiva branch November 30, 2021 11:07
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 31, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
java Java use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants