Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swift: update urls #89830

Closed
wants to merge 1 commit into from
Closed

Conversation

samford
Copy link
Member

@samford samford commented Nov 22, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

swift.org now redirects to www.swift.org, so this PR modifies the homepage to avoid the redirection as well as other URLs in the formula (for the sake of consistency). This affects the test block, so I haven't labeled this as CI-syntax-only.

@samford samford added livecheck Issues or PRs related to livecheck CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-no-bottles Merge without publishing bottles labels Nov 22, 2021
@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Nov 22, 2021
@carlocab
Copy link
Member

Building Swift takes (IIRC) 6+ hours and needs the self-hosted Linux runner, which will probably be tied up for a while. This change can probably wait for a version bump, or at least until the PRs that need it are done. Those are at least: #89488, #88036, #88210, #89262 and maybe #89642.

@samford
Copy link
Member Author

samford commented Nov 22, 2021

This change can probably wait for a version bump, or at least until the PRs that need it are done.

There's certainly no rush on these particular changes (they're just a nice-to-have rather than a need-to-have), so waiting for a version bump is fine. Do we want to leave this open (so it won't be forgotten) and cancel CI for now or should I simply close it?

@carlocab
Copy link
Member

Do we want to leave this open (so it won't be forgotten) and cancel CI for now or should I simply close it?

Either is fine with me.

@carlocab
Copy link
Member

Included in #88210.

@carlocab carlocab closed this Nov 25, 2021
@samford samford deleted the swift-update-urls branch November 26, 2021 15:23
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-bottles Merge without publishing bottles CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. livecheck Issues or PRs related to livecheck outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants