launch4j: build from source

[iMichka]

Fixes:
Full audit launch4j --git --skip-style output
launch4j:
* Binaries built for a non-native architecture were installed into launch4j's prefix.
The offending files are:
/opt/homebrew/Cellar/launch4j/3.14_1/libexec/bin/ld (x86_64)
/opt/homebrew/Cellar/launch4j/3.14_1/libexec/bin/windres (x86_64)

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[iMichka]

Actually the ld and windres files are pre-compiled.

ll /usr/local/Cellar/launch4j/3.14/libexec/bin/
total 40
-rw-r--r--  1 michkapopoff  staff    18K Nov 25 21:55 COPYING
drwxr-xr-x  5 michkapopoff  staff   160B Nov 25 21:55 bin-linux
drwxr-xr-x  5 michkapopoff  staff   160B Nov 25 21:55 bin-linux64
drwxr-xr-x  5 michkapopoff  staff   160B Nov 25 21:55 bin-macosx-x86
drwxr-xr-x  5 michkapopoff  staff   160B Nov 25 21:55 bin-win32

The info part of their website says:

Running Launch4j on other Java enabled platforms is a matter of getting a binary version of MinGW binutils 2.22 (windres and ld only) for your system or compiling them. If you'll provide these, I'll be able to create a binary package available for download.

So I think they just copy these pre-compiled binaries and ship them.

Should I disable this formula as it does not seem to fit your requirements?

==> Analytics
install: 23 (30 days), 66 (90 days), 360 (365 days)
install-on-request: 23 (30 days), 66 (90 days), 359 (365 days)
build-error: 0 (30 days)

[carlocab]

Make it depend on x86_64; I don't think we've removed any other formula that has pre-built binaries just for that reason. (Usually there are additional reasons too.)

We should probably discuss if we want to start disabling formulae like this though.

[iMichka]

On Linux:

Unwanted system libraries:
    /lib/x86_64-linux-gnu/libz.so.1

[BrewTestBot]

🤖 A scheduled task has triggered a merge.