Java Service Wrapper 3.5.46 (new formula)

[VonUniGE]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

Java Service Wrapper 3.5.46 is the fist Apple silicon compatible version. It can be used to start Sonarqube on Apple Silicon as discussed in #88380

[carlocab]

Nice work here. A few comments.

[carlocab]

A comment explaining the 1.6 here would be good.

[VonUniGE]

Ok, done.

[iMichka]

Is there a potential risk something breaks as upstream shipped with version 1.4 and probably never tested the build with 1.6? I am a little bit worried of hard-to-debug compile / runtime exceptions.

[VonUniGE]

In my opinion, the risk is limited. It all depends on your context, if this is for a development environment the risk is acceptable, if this is for a mission critical application, you should buy a server license and use the official build.

Maybe we can add a sentence in the caveats section about this ?

[carlocab]

There's no need; that caveat would apply to everything we ship.

[carlocab]

Linux failed with:

       [exec] testsuite.c:21:29: fatal error: CUnit/Automated.h: No such file or directory
       [exec] compilation terminated.
       [exec] test_example.c:15:25: fatal error: CUnit/Basic.h: No such file or directory
       [exec] compilation terminated.
       [exec] test_javaadditionalparam.c:15:25: fatal error: CUnit/Basic.h: No such file or directory
       [exec] compilation terminated.
       [exec] test_hashmap.c:15:25: fatal error: CUnit/Basic.h: No such file or directory
       [exec] compilation terminated.
       [exec] test_filter.c:15:25: fatal error: CUnit/Basic.h: No such file or directory
       [exec] compilation terminated.
       [exec] wrapper.c:52:25: fatal error: CUnit/Basic.h: No such file or directory
       [exec] compilation terminated.
       [exec] make: *** [testsuite] Error 1
       [exec] make: *** Waiting for unfinished jobs....
       [exec] Makefile-linux-x86-64.make:44: recipe for target 'testsuite' failed

[iMichka]

Yes, you need to add depends_on "cunit" => :build for Linux only.

[carlocab]

Thanks, @VonUniGE!

[BrewTestBot]

@carlocab has triggered a merge.