Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java Service Wrapper 3.5.46 (new formula) #90008

Closed
wants to merge 6 commits into from
Closed

Java Service Wrapper 3.5.46 (new formula) #90008

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4333d73
Java Service Wrapper 3.5.46 (new formula)
VonUniGE Nov 23, 2021
3fd3ef0
Add ant as a build dependency
VonUniGE Nov 26, 2021
bd47ea3
Add comment on the choice of javac.target.version=1.6
VonUniGE Nov 26, 2021
b963870
Order dependencies alphabetically
VonUniGE Nov 26, 2021
0849e37
Add assert_match on test section
VonUniGE Nov 26, 2021
9aefc21
Add CUnit as a Linux dependency
VonUniGE Nov 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions Formula/java-service-wrapper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
class JavaServiceWrapper < Formula
desc "Simplify the deployment, launch and monitoring of Java applications"
homepage "https://wrapper.tanukisoftware.com/"
url "https://downloads.sourceforge.net/project/wrapper/wrapper_src/Wrapper_3.5.46_20210903/wrapper_3.5.46_src.tar.gz"
sha256 "82e1d0c85488d1389d02e3abe3359a7f759119e356e3e3abd6c6d67615ae5ad8"
license "GPL-2.0-only"

depends_on "ant" => :build
depends_on "openjdk@11" => :build
on_linux do
depends_on "cunit" => :build
end

def install
ENV["JAVA_HOME"] = Formula["openjdk@11"].opt_prefix
# Default javac target version is 1.4, use 1.6 which is the minimum available on openjdk@11
system "ant", "-Dbits=64", "-Djavac.target.version=1.6"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment explaining the 1.6 here would be good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a potential risk something breaks as upstream shipped with version 1.4 and probably never tested the build with 1.6? I am a little bit worried of hard-to-debug compile / runtime exceptions.

Copy link
Contributor Author

@VonUniGE VonUniGE Nov 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, the risk is limited. It all depends on your context, if this is for a development environment the risk is acceptable, if this is for a mission critical application, you should buy a server license and use the official build.

Maybe we can add a sentence in the caveats section about this ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need; that caveat would apply to everything we ship.

libexec.install "lib", "bin", "src/bin" => "scripts"
end

test do
output = shell_output("#{libexec}/bin/testwrapper status", 1)
assert_match("Test Wrapper Sample Application", output)
end
end