Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

druid: fix test for Linux #90196

Closed
wants to merge 1 commit into from
Closed

druid: fix test for Linux #90196

wants to merge 1 commit into from

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Nov 30, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@iMichka
Copy link
Member Author

iMichka commented Nov 30, 2021

I'll upstream my patch if it works.

@BrewTestBot BrewTestBot added the java Java use is a significant feature of the PR or issue label Nov 30, 2021
@iMichka iMichka force-pushed the druid branch 3 times, most recently from cb3eec8 to 9900ecb Compare November 30, 2021 21:51
@iMichka
Copy link
Member Author

iMichka commented Dec 1, 2021

Waiting for a quick upstream patch review: apache/druid#12014

@iMichka
Copy link
Member Author

iMichka commented Dec 6, 2021

Upstream merged the patch. As the folder structure of their release tarball is different, I am keeping the slightly different inline patch for now. I added a comment to remove this patch for the next release.

@iMichka iMichka added the ready to merge PR can be merged once CI is green label Dec 6, 2021
@iMichka iMichka mentioned this pull request Dec 9, 2021
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚀

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@iMichka iMichka deleted the druid branch December 12, 2021 19:58
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 12, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
java Java use is a significant feature of the PR or issue outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants