Skip to content
This repository has been archived by the owner on Jan 16, 2025. It is now read-only.

libmemcached: fix osx yosemite build #30139

Closed
wants to merge 2 commits into from
Closed

libmemcached: fix osx yosemite build #30139

wants to merge 2 commits into from

Conversation

denji
Copy link
Contributor

@denji denji commented Jun 14, 2014

Important this patch make cross-platform compatibility, there were problems of compatibility byterage.

  CXX      libmemcached/libmemcached_libmemcached_la-byteorder.lo
libmemcached/byteorder.cc:66:10: error: use of undeclared identifier 'ntohll'
  return ntohll(value);
         ^
libmemcached/byteorder.cc:75:10: error: use of undeclared identifier 'htonll'
  return htonll(value);
         ^
2 errors generated.

Install without waiting homebrew pull:

brew install https://raw.github.com/denji/homebrew/56eaf3c/Library/Formula/libmemcached.rb
brew link --overwrite --force libmemcached

make cross-platform compatiblity
@mistydemeo
Copy link
Contributor

Have you reported this to the developers? Are you the author of the patch?

@MikeMcQuaid
Copy link
Member

Please report this upstream to the libmemcached developers and link your submission in here. We'll probably not include the patch until upstream does.

@Maxwell2022
Copy link

+1
Is there any way I could bypass this issue to install libmemcached until it's fixed upstream?

@Maxwell2022
Copy link

Thanks @denji, I didn't see your install link.

@adamv adamv added the 10.10 label Jun 23, 2014
@zackify
Copy link

zackify commented Aug 11, 2014

This patch works, it would be nice if it got merged.

@MikeMcQuaid
Copy link
Member

@Maxwell2022 @zackify The quickest way to get this PR accepted is for someone to submit it upstream.

@ablyler
Copy link
Contributor

ablyler commented Aug 12, 2014

Link to the bug in libmemcached: https://bugs.launchpad.net/libmemcached/+bug/1245562

@glynjackson
Copy link

+1 on this to be merged please :)

@MikeMcQuaid
Copy link
Member

@BrewTestBot test this please

@MikeMcQuaid
Copy link
Member

@Sparky300 A "+1" doesn't really help us but emails all the maintainers anyway. Please don't do them in future, thanks!

@jacknagel
Copy link
Contributor

Closed by 45bcde2

@jacknagel jacknagel closed this Aug 28, 2014
@denji denji deleted the libmemcached branch August 28, 2014 17:05
@Homebrew Homebrew locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants