fltk build fix

[scr34m]

Fixes #33093

Tested with tiger-vnc which is uses fltk

[jacknagel]

Still failing on 10.10...

Also please remove "Fixes #29988" from the commit message, that's a more general thread that we don't want to be closed when this is merged.

[DomT4]

I'd be extremely happy to see the larger thread closed by a PR that fixes all of the existing issues though 😉.

I'm not quite sure what's going on with this. I get the same set of compile/preprocessor errors, but:

==> Summary
🍺  /usr/local/Cellar/fltk/1.3.2_1: 315 files, 5.8M, built in 2.3 minutes

And it runs fine as well 😕

[scr34m]

Commit message changed

Here is my install log https://gist.github.com/scr34m/a79fa8e3bc34138875c8 so we could be a bit specific :)

These errors found, maybe caused by autotools or simply just need to fix "again", here is a ticket about cmake / autotools http://www.fltk.org/str.php?L2916

clang: error: unsupported option '-V -isystem/usr/local/include'
clang: error: unknown argument: '-qversion'
conftest.c:50:10: fatal error: 'sys/stdtypes.h' file not found
conftest.c:67:10: fatal error: 'libpng/png.h' file not found
configure:6381: WARNING: pthread.h: accepted by the compiler, rejected by the preprocessor!

Here is the output of my install run

==> Summary
/usr/local/Cellar/fltk/1.3.2_1: 315 files, 5,8M, built in 110 seconds

[jacknagel]

The "errors" during configure are not really errors, that's just how autotools detects features.

[jacknagel]

(the failure on the bot is here: http://bot.brew.sh/job/Homebrew%20Pull%20Requests/16274/version=yosemite/testReport/junit/brew-test-bot/yosemite/install_fltk/)

[scr34m]

@jacknagel yes already checking, but the problematic part passed sucessfully (Fl_cocoa.mm compile issue)

=== installing src ===
Compiling Fl_cocoa.mm...
Compiling Fl_Quartz_Printer.mm...

One problematic part is compiled on my machine sucessfully (copied from my gist):

Compiling file_chooser.cxx...
Linking file_chooser...
Creating 'file_chooser.app' bundle for desktop...

But this error message "FAILED TO establish the default connection to the WindowServer" is telling the reason isnt?

[scr34m]

Upstream patched the 1.3 branch see http://www.fltk.org/str.php?L3141

[jacknagel]

@MikeMcQuaid Any idea about the WindowServer errors on 10.10?

http://bot.brew.sh/job/Homebrew%20Testing/version=yosemite/708/testReport/junit/brew-test-bot/yosemite/install_fltk/

We keep seeing:

 FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL.

in this case it happens during compilation, but we saw the same error in the test for #33458.

The 10.8 and 10.9 bots seem OK.

[DomT4]

There are some known, significant errors on 10.10 with the WindowServer. It is expected that Apple will drop a 10.10.1 reasonably soon with a fix.

[DomT4]

(Although from that error the WindowServer errors may have less to do with the known issues and more something like discussed here previously?). ❓

[jacknagel]

If it was a previously known issue, I would expect it to manifest on all three bots.

[MikeMcQuaid]

@jacknagel Not sure I'm afraid; I don't think the bot seems to like running any sort of windowed applications any more.