Proxy support #27
Proxy support #27
Conversation
| @@ -1,4 +1,4 @@ | |||
| "use strict"; | |||
| /// <reference path="../../typings/vscode-typings.d.ts" /> | |||
There was a problem hiding this comment.
@mad-mike I have a question that why adding this line and removing the strict mode?
There was a problem hiding this comment.
I found that the typescript compiler will introduce "use strict" anyway, so I removed that line.
Then I added the ref to the type definitions in order to get IntelliSense for the vscode API.
There was a problem hiding this comment.
@mad-mike, I found even without this line, I can still get IntelliSense with vscode. And I think we can remove this line, together with the 'use strict' line
There was a problem hiding this comment.
@Huachao, you are right. Explicit typings are only necessary for npm packages that don't contain them out of the box, as it seems (http://www.typescriptlang.org/docs/handbook/typings-for-npm-packages.html). I'm going to save a few lines of code from now on ;)
|
Merged, thanks |
implementing #25