-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship Humanizer 2.1 #567
Comments
I am working to port Numbro to Humanizer. The related issue is #558. The PR should be ready as soon as #568 is fixed and I achieve to build 😄 Also:
One item should be ready:
|
I would like to nominate following: (moved to the first message) |
@onovotny Can you update the milestone in each issue/PR? |
What if we just let the GitVersion decide the next version number? This will allow us to just ship without looking into the details and version holds. |
@hazzik GitVersion is just a tool...it does whatever we want it to. In general, here's a good take on it: By that logic, it feels like a 2.1 for this release. |
I know that this shall be a 2.1. But what I'm trying to say: we do |
Hey-hey. I've merged #566. 🚢 the 2.1. |
I generally tag the final version and that will automatically set it in GitVersion |
Note that Humanizer is completely broken on dotnet CLI due to this: https://github.com/dotnet/cli/issues/3396. It won't install/restore succesfully. Only the english locale will work, Try it today with the MyGet/CI feed; you cannot restore it into an xproj. It works just fine in a csproj that uses netstandard. |
I may have a workaround for this that I'm testing -- a |
Confirmed, the |
2.1 has been pushed to NuGet. Should be visible soon. |
Issue to track shipping Humanizer 2.1.
In addition to the bug fixes since
2.0.1
, this version will supportnetstandard
. As such, it will also require a minimum NuGet version of2.12
to install correctly.@hazzik @aloisdg @mexx Please add items to this list that need to be complete before we ship.
netstandard
branchThe text was updated successfully, but these errors were encountered: