Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsiveness #1458

Merged
merged 12 commits into from
Feb 5, 2025
Merged

Responsiveness #1458

merged 12 commits into from
Feb 5, 2025

Conversation

peach280
Copy link
Contributor

Pull Requests Requirements

  • The PR title includes a brief description of the work done, including the
    Issue number if applicable.
  • The PR title follows conventional commit label standards.
  • The changes confirm to the OpenElis Global x3 Styleguide and design
    documentation.
  • I have read and agree to the Contributing Guidelines of this project.

Summary

Fixes #1447

This pull request fixes the issue of irresponsive design of non conform pages. This design works good on ipad, iphone and PC
Please review and provide your valuable feedback .

Video of the change

OpenELIS.-.Google.Chrome.2025-01-29.00-17-47.mp4

As seen in the above video, in ipad screen mode as well as iphone, the design is responsive.

Copy link

👋 Hi, @peach280,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict Merge Conflicts label Jan 29, 2025
@peach280
Copy link
Contributor Author

peach280 commented Jan 29, 2025

Ok, I have resolved the merging conflicts

@github-actions github-actions bot removed the merge conflict Merge Conflicts label Jan 29, 2025
@peach280
Copy link
Contributor Author

peach280 commented Feb 4, 2025

Hi @mozzy11, I have made the design almost responsive, but can I get a sample lab number so that I can check the responsiveness after entering the values too.

@mozzy11
Copy link
Collaborator

mozzy11 commented Feb 5, 2025

Thanks @peach280 , can you run the frontend formatter to fix the CI build ??

@peach280
Copy link
Contributor Author

peach280 commented Feb 5, 2025

Yes I have committed the required changes. Please check

Signed-off-by: Vaishnavi Bhandari <[email protected]>
Signed-off-by: Vaishnavi Bhandari <[email protected]>
@mozzy11
Copy link
Collaborator

mozzy11 commented Feb 5, 2025

did you just add the chane in index.css again ??

@peach280
Copy link
Contributor Author

peach280 commented Feb 5, 2025

The change in index.css is automatically made whenever I run npm run format for formatting the code

@mozzy11
Copy link
Collaborator

mozzy11 commented Feb 5, 2025

what node version do you have locally ??

@peach280
Copy link
Contributor Author

peach280 commented Feb 5, 2025

v16.20.2

@mozzy11
Copy link
Collaborator

mozzy11 commented Feb 5, 2025

can you update it to 20+ ?? and run the formatter again ??
The issue could be brought because of difrerent node versions in the CI and your local enviroment

Signed-off-by: Vaishnavi Bhandari <[email protected]>
@peach280
Copy link
Contributor Author

peach280 commented Feb 5, 2025

I changed node version to 20+ but it was still changing index.css so I manually stopped it from doing so.

@mozzy11 mozzy11 merged commit 6bfad08 into I-TECH-UW:develop Feb 5, 2025
4 checks passed
@peach280 peach280 mentioned this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Responsiveness for the Non Conform Pages
2 participants