-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Responsiveness #1458
Responsiveness #1458
Conversation
Signed-off-by: Vaishnavi Bhandari <[email protected]>
Signed-off-by: Vaishnavi Bhandari <[email protected]>
👋 Hi, @peach280, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
Ok, I have resolved the merging conflicts |
Hi @mozzy11, I have made the design almost responsive, but can I get a sample lab number so that I can check the responsiveness after entering the values too. |
Thanks @peach280 , can you run the frontend formatter to fix the CI build ?? |
Signed-off-by: Vaishnavi Bhandari <[email protected]>
…-Global-2 into responsiveness
Yes I have committed the required changes. Please check |
Signed-off-by: Vaishnavi Bhandari <[email protected]>
Signed-off-by: Vaishnavi Bhandari <[email protected]>
did you just add the chane in index.css again ?? |
The change in index.css is automatically made whenever I run npm run format for formatting the code |
what node version do you have locally ?? |
v16.20.2 |
can you update it to 20+ ?? and run the formatter again ?? |
Signed-off-by: Vaishnavi Bhandari <[email protected]>
I changed node version to 20+ but it was still changing index.css so I manually stopped it from doing so. |
Pull Requests Requirements
Issue number if applicable.
documentation.
Summary
Fixes #1447
This pull request fixes the issue of irresponsive design of non conform pages. This design works good on ipad, iphone and PC
Please review and provide your valuable feedback .
Video of the change
OpenELIS.-.Google.Chrome.2025-01-29.00-17-47.mp4
As seen in the above video, in ipad screen mode as well as iphone, the design is responsive.