Fix for #1624 and #1623: Bootstrap_Nav_Walker::start_el() continued #1625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
As noted in #1623 (comment), cannot use object of type stdClass as array in
largo/inc/nav-menus.php:87
. This PR reverts to the pre-#1624 behavior of accessing the various aspects of the$args
argument as object properties, not as array keys.I'm not sure what caused #1623, in the end, and that's worrisome.
However, this patch unbreaks the error that #1624 introduced.