You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
wrong structure of solution (in particular too many files and in wrong directory) -1
sloppy style of documentation of functions -1
inconsistent style - e.g. no braces after if statement -0,5
functions are not separated by new lines (it is hard to see where the previous function finishes and a new starts) -0,5
using exceptions in non-exceptional context e.g. throwing when some congruence equation does not have a solution - 1
last but not least - the main function of you project - solving system of modular equations does not support (does not work) in the general case of not coprime mods. -2pt.
There are other problems with your code e.g. inline comments - however I think you put some effort in implementing this project + you provided nice test so summing up the above issues you receive: 9 - 6 + 1= 4pts
The text was updated successfully, but these errors were encountered:
There are many issues:
There are other problems with your code e.g. inline comments - however I think you put some effort in implementing this project + you provided nice test so summing up the above issues you receive: 9 - 6 + 1= 4pts
The text was updated successfully, but these errors were encountered: