Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrete Math basic num theory pack #13

Open
lemkis opened this issue May 20, 2024 · 0 comments
Open

Discrete Math basic num theory pack #13

lemkis opened this issue May 20, 2024 · 0 comments

Comments

@lemkis
Copy link
Collaborator

lemkis commented May 20, 2024

There are many issues:

  • wrong structure of solution (in particular too many files and in wrong directory) -1
  • sloppy style of documentation of functions -1
  • inconsistent style - e.g. no braces after if statement -0,5
  • functions are not separated by new lines (it is hard to see where the previous function finishes and a new starts) -0,5
  • using exceptions in non-exceptional context e.g. throwing when some congruence equation does not have a solution - 1
  • last but not least - the main function of you project - solving system of modular equations does not support (does not work) in the general case of not coprime mods. -2pt.

There are other problems with your code e.g. inline comments - however I think you put some effort in implementing this project + you provided nice test so summing up the above issues you receive: 9 - 6 + 1= 4pts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant