Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polynomial project evaluation #15

Open
lemkis opened this issue May 20, 2024 · 1 comment
Open

polynomial project evaluation #15

lemkis opened this issue May 20, 2024 · 1 comment

Comments

@lemkis
Copy link
Collaborator

lemkis commented May 20, 2024

  • wrong structure of project -1pt
  • no descriptions of functions in hpp file -1pt
  • root_rational_candidates too long and logic should be divided (we have written a proper version of this function together - why did you not use it?) -1pt
  • line 177 overload of << - you should have overloaded std::formatter as is done in all other projects and std::print instead of std::cout -1pt
  • style inconsistency e.g. naming - performoperation + logical error - performoperation's third argument should be char not string -1pt
  • example function is too long -1pt
  • no tests -1pt

I met with you last week and i mentioned 7 out of 7 of this issues and you have not corrected them.

Final score 9 - 7 = 2 pts

@lemkis
Copy link
Collaborator Author

lemkis commented Jun 17, 2024

You corrected many thins but still there are many issues e.g.:
-you did not address some of above remarks

  • printing of polynomial is poor - you did not use some modern solutions like std::formatter so not for example it is hard to understand your examples
  • code duplication e.g. when finding factors of leading and constant coefficient
  • testing is poor
  • you clearly do not pass clang tidy checks e.g. vectors in lines 270-271 should be const.

Final score: +1pt to you previous score which makes 3 pts for this project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant