Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidecar cannot reach storage #1264

Closed
Tracked by #951
bisgaard-itis opened this issue Feb 12, 2024 · 8 comments
Closed
Tracked by #951

Sidecar cannot reach storage #1264

bisgaard-itis opened this issue Feb 12, 2024 · 8 comments
Assignees
Milestone

Comments

@bisgaard-itis
Copy link
Contributor

bisgaard-itis commented Feb 12, 2024

Placeholder for https://z43.manuscript.com/f/cases/191098/service-failed-sidecar-cannot-reach-storage

@matusdrobuliak66
Copy link
Contributor

@YuryHrytsuk
Copy link
Contributor

It is awaiting @GitHK changes in dynamic-sidecar. As soon as, dynamic-sidecar uses the new endpoint and all works, we can close it

@YuryHrytsuk
Copy link
Contributor

The fix is merged. We will observe it for a couple of days before closing

@sanderegg
Copy link
Member

Just a remark on this "fix":

  • spaghetti code: Dynamic-sidecar --> storage uses https,
  • all other services use regular http
    As much as I understand the need for this fix I think the solution is half backed and will only increase code complexity and understanding.

I would be more than happy that at least references to this issue are set in the osparc-simcore code because otherwise it makes no sense.
@GitHK @YuryHrytsuk

@GitHK
Copy link
Contributor

GitHK commented Feb 29, 2024

@sanderegg I'll drop a refenrece to the issue in one of my PRs

@YuryHrytsuk
Copy link
Contributor

Just a remark on this "fix":

* spaghetti code: Dynamic-sidecar --> storage uses https,

* all other services use regular http
  As much as I understand the need for this fix I think the solution is half backed and will only increase code complexity and understanding.

I would be more than happy that at least references to this issue are set in the osparc-simcore code because otherwise it makes no sense. @GitHK @YuryHrytsuk

This is true. The fix doesn't seem to be the best solution. On the other hand I don't see any other solution to the problem. And the main issue is that we still don't fully understand the root of the problem (also because it is not easy to reproduce).

I don't feel that any of us will dive deep into docker for a couple of days (or a week) to find out the root cause.

Any proposals how to get away from current position?

@sanderegg @GitHK @mrnicegyu11

@mrnicegyu11
Copy link
Member

One invasive suggestion to improve the current state and at least reestablish code homogenity:

  • We decide the storage microservice is now publicly accessible
  • We really mean it and make its openapi specs public
  • We enforce all simcore-microservices to talk to storage via a public route by explicitly changing the docker-internal DNS name of storage so all microservices talking via http/internally will fail

@YuryHrytsuk
Copy link
Contributor

After this solution was introduced to master deployment, storage failures never occurred. I consider this issue to be fixed as of now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants