Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change agent deploy policy #115

Merged
merged 2 commits into from
Mar 14, 2023
Merged

change agent deploy policy #115

merged 2 commits into from
Mar 14, 2023

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Mar 14, 2023

Since the agent registers RPC calls on startup and these cannot overlap, it is required that the service is fully stopped before a new instance is started.

@mrnicegyu11 I hope this is the correct place to change it

@mrnicegyu11
Copy link
Member

thanks a lot for this! It is the correct place to change it! I am not an expert for the particular change you made, i.e. for the restart-policies, maybe sylvain can better assess if this change brings what you need.

Supernice, thanks again!
Please somehow reference/tag this PR in your associated simcore PR so it is not forgotten that they go together :)

@GitHK
Copy link
Contributor Author

GitHK commented Mar 14, 2023

@mrnicegyu11 it is linked back with instructions that it is required when deploying to be in the target deployment

@GitHK GitHK merged commit 2187782 into main Mar 14, 2023
@GitHK GitHK deleted the change-agent-deploy-sequence branch March 14, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants