Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mypy issues ASAP #6115

Closed
17 tasks done
sanderegg opened this issue Jul 26, 2024 · 0 comments
Closed
17 tasks done

Fix Mypy issues ASAP #6115

sanderegg opened this issue Jul 26, 2024 · 0 comments
Assignees
Labels
bug buggy, it does not work as expected High Priority a totally crucial bug/feature to be fixed asap t:maintenance Some planned maintenance work
Milestone

Comments

@sanderegg
Copy link
Member

sanderegg commented Jul 26, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Planned changes

Fixing the mypy issues all over the repo is of the highest importance, as a few important bugs are found (such as misuse of libraries and some other wrongly typed calls).
Therefore an action must be taken on the backend side ASAP.

All the libraries where continue-on-error: true is found in .github/workflows/ci-testing-deploy.yml must be tackled.

Tasks

Preview Give feedback
  1. a:api t:maintenance
    pcrespov

procedure

# go to package
make install-dev
make mypy
# enjoy
  1. add in setup.cfg:
[mypy]
plugins =
	pydantic.mypy

or

[mypy]
plugins =
	pydantic.mypy
	sqlalchemy.ext.mypy.plugin

if using also sqlalchemy in the service/package
3. add needed types-aiofiles or others in the _test.in requirements (as suggested by mypy)

cd requirements
make touch reqs upgrade=types
  1. remove continue-on-error: true in https://github.com/ITISFoundation/osparc-simcore/blob/fb5b8b5ce9ccc5131adbb75cab4e0311d7aefde7/.github/workflows/ci-testing-deploy.yml
@sanderegg sanderegg added the t:maintenance Some planned maintenance work label Jul 26, 2024
@sanderegg sanderegg added this to the Tom Bombadil milestone Jul 26, 2024
@sanderegg sanderegg added High Priority a totally crucial bug/feature to be fixed asap bug buggy, it does not work as expected labels Jul 26, 2024
@sanderegg sanderegg modified the milestones: Tom Bombadil, Eisbock Aug 13, 2024
This was referenced Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug buggy, it does not work as expected High Priority a totally crucial bug/feature to be fixed asap t:maintenance Some planned maintenance work
Projects
None yet
Development

No branches or pull requests

3 participants