Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Is3683/traefik invitations rules (⚠️ devops) #3787

Closed

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jan 23, 2023

What do these changes do?

Following the changes requested by @sirtoobii, this PR allows the invitations service http-API to be reachable from outside using basic-auth.

Changes highlights

  • traefik rules for the invitations service
  • enable/disable auth in invitations (might add the auth in traefik) -> toggle auth increases complexity too much. Will remove all auth when reverse-proxy activates it.

⚠️ devops

invitations service API is accessible via new entrypoint simcore_invitations.address=:10082

  • Please check traefik labels in docker-compose
  • Please check network associated to invitations service for security issues
  • The invitations http has to be routed to https://invitations.$(hostname) where hostname can be
    • s4l-lite-master.speag.com
    • s4l-lite-staging.speag.com
    • s4l-lite.speag.com
    • staging.s4l-lite.io
    • s4l-lite.io
  • NOTE: the invitations service still includes basic-auth but we intend to move it to the reverse-proxy in a separate PR (for simplicity).

image

Related issue/s

How to test

  • See traefik console image above

Checklist

  • make version-*
  • make openapi.json
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes

@pcrespov pcrespov self-assigned this Jan 23, 2023
@pcrespov pcrespov marked this pull request as draft January 23, 2023 14:51
@pcrespov pcrespov changed the title ✨ Is3683/traefik invitations rules (⚠️ devops) WIP: ✨ Is3683/traefik invitations rules (⚠️ devops) Jan 23, 2023
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #3787 (dd0db1f) into master (2bd6848) will decrease coverage by 4.4%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3787     +/-   ##
========================================
- Coverage    84.8%   80.4%   -4.4%     
========================================
  Files         920     920             
  Lines       39131   39130      -1     
  Branches      793     793             
========================================
- Hits        33190   31499   -1691     
- Misses       5731    7421   +1690     
  Partials      210     210             
Flag Coverage Δ
integrationtests 61.7% <ø> (-5.1%) ⬇️
unittests 77.9% <100.0%> (-4.0%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/simcore_service_invitations/api/_dependencies.py 100.0% <100.0%> (ø)
...rc/simcore_service_invitations/api/_invitations.py 100.0% <100.0%> (ø)
...invitations/src/simcore_service_invitations/cli.py 93.3% <100.0%> (+0.1%) ⬆️
...r/src/simcore_service_webserver/storage_schemas.py 0.0% <0.0%> (-100.0%) ⬇️
...service_webserver/projects/_project_models_rest.py 0.0% <0.0%> (-100.0%) ⬇️
...erver/src/simcore_service_webserver/rest_models.py 0.0% <0.0%> (-92.7%) ⬇️
...simcore_service_webserver/director/director_api.py 0.0% <0.0%> (-76.0%) ⬇️
...src/simcore_service_webserver/activity/handlers.py 29.3% <0.0%> (-63.8%) ⬇️
...ce_webserver/studies_dispatcher/_studies_access.py 22.7% <0.0%> (-63.7%) ⬇️
...ver/src/simcore_service_webserver/catalog_units.py 24.0% <0.0%> (-61.2%) ⬇️
... and 77 more

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@pcrespov pcrespov force-pushed the is3683/traefik-invitations-rules branch from 185d944 to d42dbcb Compare January 23, 2023 19:09
@pcrespov pcrespov changed the title WIP: ✨ Is3683/traefik invitations rules (⚠️ devops) ✨ Is3683/traefik invitations rules (⚠️ devops) Jan 23, 2023
@pcrespov pcrespov marked this pull request as ready for review January 23, 2023 20:38
@pcrespov pcrespov requested review from sanderegg and Surfict January 23, 2023 20:38
@pcrespov pcrespov added this to the Resistance Is Futile milestone Jan 23, 2023
@pcrespov pcrespov force-pushed the is3683/traefik-invitations-rules branch from e3aecdd to dd0db1f Compare January 24, 2023 13:09
@codeclimate
Copy link

codeclimate bot commented Jan 24, 2023

Code Climate has analyzed commit dd0db1f and detected 0 issues on this pull request.

View more on Code Climate.

@pcrespov pcrespov mentioned this pull request Jan 24, 2023
8 tasks
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov enabled auto-merge (squash) January 24, 2023 13:20
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,
will not approve for now since this is blocked until there is a matching ops PR.

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking this until the matching ops PR is in

@pcrespov
Copy link
Member Author

This approach was dropped in favor or https://git.speag.com/oSparc/osparc-ops-environments/-/issues/395

@pcrespov pcrespov closed this Jan 25, 2023
auto-merge was automatically disabled January 25, 2023 17:05

Pull request was closed

@pcrespov pcrespov deleted the is3683/traefik-invitations-rules branch January 25, 2023 17:05
pcrespov added a commit to pcrespov/osparc-simcore that referenced this pull request Jan 30, 2023
pcrespov added a commit to pcrespov/osparc-simcore that referenced this pull request Jan 31, 2023
pcrespov added a commit to pcrespov/osparc-simcore that referenced this pull request Jan 31, 2023
pcrespov added a commit to pcrespov/osparc-simcore that referenced this pull request Jan 31, 2023
pcrespov added a commit to pcrespov/osparc-simcore that referenced this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants