-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Is3683/traefik invitations rules (⚠️ devops) #3787
✨ Is3683/traefik invitations rules (⚠️ devops) #3787
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3787 +/- ##
========================================
- Coverage 84.8% 80.4% -4.4%
========================================
Files 920 920
Lines 39131 39130 -1
Branches 793 793
========================================
- Hits 33190 31499 -1691
- Misses 5731 7421 +1690
Partials 210 210
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
185d944
to
d42dbcb
Compare
bcfaa27
to
3459785
Compare
e3aecdd
to
dd0db1f
Compare
Code Climate has analyzed commit dd0db1f and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm,
will not approve for now since this is blocked until there is a matching ops PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking this until the matching ops PR is in
This approach was dropped in favor or https://git.speag.com/oSparc/osparc-ops-environments/-/issues/395 |
Pull request was closed
What do these changes do?
Following the changes requested by @sirtoobii, this PR allows the
invitations
service http-API to be reachable from outside using basic-auth.Changes highlights
invitations
serviceenable/disable auth in invitations (might add the auth in traefik)-> toggle auth increases complexity too much. Will remove all auth when reverse-proxy activates it.invitations
service API is accessible via new entrypointsimcore_invitations.address=:10082
invitations
service for security issuesinvitations
http has to be routed tohttps://invitations.$(hostname)
wherehostname
can bes4l-lite-master.speag.com
s4l-lite-staging.speag.com
s4l-lite.speag.com
staging.s4l-lite.io
s4l-lite.io
invitations
service still includes basic-auth but we intend to move it to the reverse-proxy in a separate PR (for simplicity).Related issue/s
How to test
Checklist
make version-*
make openapi.json