♻️ volumes are removed via agent (⚠️ devops)

[GitHK]

⚠️ devops

• rabbitmq data is now backed up to the rabbit_data volume. It is required that after the server restart, this goes to the same volume
• agent service has new env vars which should be automatically picked up from the existing configuration
• ⚠️ the following change needs to be propagated to the deployment where this is being released change agent deploy policy osparc-ops-environments#115
• docker version is no longer limited since this PR invalidates docker version parsing #3946

To note:

• if rabbitmq is restarted the agent and director-v2 will reconnect automatically reconnect. RPC calls will be delivered normally
• if there is an connection error (to rabbitmq) while making an RPC call, the call is retried

What do these changes do?

The agent service running on node X will now remove volumes when the dynamic-sidecar was closed.
No longer creates services which are responsible for removing these volumes via bash commands.

• ♻️ director-v2 will no longer create a service when removing the volumes used by the dy-sidecar. Instead it will ask the agent to remove the volumes. Requests are delivered via rabbitmq
• ⚰️ dy-vol-rm service code has been removed (dy-volume remover is running BASH script instead of posix SH script... osparc-issues#763)
• ✨ the agent, running on a specific node, will now remove volumes via RabbitMQ RPC call. (Refactor volume removal #3446)
• 🐛 volume_removal job from the agent can no longer fail because of the volume being removed while it is running. (Volume removal and simcore agent issue #3890)
• ♻️ rpc_request is now resilient to rabbit connection errors

TODOs:

• refactor agent internals to use a queue of actions when removing volumes, avoids any possible concurrency issues with volume removal
• if the agent running on a specific node is gone what to do? need a test to simulate (this can happen with autoscaling nodes)
• fix agent tests after refactor (the rabbitmq removal is still failing in the tests)
• fix deictor-v2 tests after the refactor
• test if changes work as expected

Related issue/s

How to test

Checklist

• Unit tests for the changes exist
• Runs in the swarm

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.2%. Comparing base (7ebcf27) to head (de6916d).
Report is 1337 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (7ebcf27) and HEAD (de6916d). Click for more details.

HEAD has 7 uploads less than BASE

Flag	BASE (7ebcf27)	HEAD (de6916d)
unittests	19	14
integrationtests	5	3

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #3941      +/-   ##
=========================================
- Coverage    85.4%   80.2%    -5.3%     
=========================================
  Files         868     587     -281     
  Lines       37950   23895   -14055     
  Branches      885     435     -450     
=========================================
- Hits        32429   19175   -13254     
+ Misses       5318    4621     -697     
+ Partials      203      99     -104     

Flag	Coverage Δ
integrationtests	62.9% <ø> (+0.1%)	⬆️
unittests	78.2% <ø> (-5.4%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 498 files with indirect coverage changes

[codeclimate]

Code Climate has analyzed commit de6916d and detected 0 issues on this pull request.

View more on Code Climate.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.1% Duplication

[YuryHrytsuk]

⚠️ the following change needs to be propagated to the deployment where this is being released ITISFoundation/osparc-ops-environments#115

What do you mean? The PR is already merged and its changes are in use.

[GitHK]

⚠️ the following change needs to be propagated to the deployment where this is being released ITISFoundation/osparc-ops-environments#115

What do you mean? The PR is already merged and its changes are in use.

I will pick this one up in the future there is no activity here since moths