Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use forked openapi generator repo #4343

Merged
merged 5 commits into from
Jun 13, 2023
Merged

Use forked openapi generator repo #4343

merged 5 commits into from
Jun 13, 2023

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Jun 12, 2023 •
edited
Loading

What do these changes do?

Start using this fork of the openapi-generator repo to maintain templates for the python client.

Related issue/s

  • related to

How to test

DevOps Checklist

@bisgaard-itis bisgaard-itis requested a review from pcrespov as a code owner June 12, 2023 11:52
@bisgaard-itis bisgaard-itis self-assigned this Jun 12, 2023
pcrespov
pcrespov approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!
NOTE: do not forget to fill the PR's attributes (e.g. labels, milestone, etc)

@codecov
Copy link

codecov bot commented Jun 12, 2023 •
edited
Loading

Codecov Report

Merging #4343 (00f4bbd) into master (b7f2df6) will decrease coverage by 5.8%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4343      +/-   ##
=========================================
- Coverage    83.3%   77.6%    -5.8%     
=========================================
  Files         428      62     -366     
  Lines       22182    1775   -20407     
  Branches      173       0     -173     
=========================================
- Hits        18486    1378   -17108     
+ Misses       3647     397    -3250     
+ Partials       49       0      -49
Flag Coverage Δ
integrationtests ?
unittests 77.6% <ø> (-2.4%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 490 files with indirect coverage changes

@bisgaard-itis bisgaard-itis added the a:api framework api, data schemas, label Jun 12, 2023
@bisgaard-itis bisgaard-itis added this to the Watermelon milestone Jun 12, 2023
@bisgaard-itis bisgaard-itis enabled auto-merge (squash) June 13, 2023 07:41
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Jun 13, 2023

Code Climate has analyzed commit 00f4bbd and detected 0 issues on this pull request.

View more on Code Climate.

@bisgaard-itis bisgaard-itis merged commit 63b5ef7 into ITISFoundation:master Jun 13, 2023
@pcrespov pcrespov mentioned this pull request Jun 21, 2023
Closed
20 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 22, 2023
Closed
34 tasks
@sanderegg sanderegg mentioned this pull request Jun 26, 2023
Closed
@bisgaard-itis bisgaard-itis deleted the use-forked-openapi-generator-repo branch October 25, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

Assignees

@bisgaard-itis bisgaard-itis

Labels
a:api framework api, data schemas,
Projects
None yet
Milestone
Watermelon
Development

Successfully merging this pull request may close these issues.
3 participants
@bisgaard-itis @pcrespov @matusdrobuliak66