Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client generation #4366

Merged

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Jun 14, 2023

What do these changes do?

Streamline generation of generation of client.
This should make it easier to generate both the python and the c client.

Related issue/s

#4345

How to test

DevOps Checklist

@bisgaard-itis bisgaard-itis requested a review from pcrespov as a code owner June 14, 2023 13:11
@bisgaard-itis bisgaard-itis self-assigned this Jun 14, 2023
@bisgaard-itis bisgaard-itis added the a:api framework api, data schemas, label Jun 14, 2023
@bisgaard-itis bisgaard-itis added this to the Watermelon milestone Jun 14, 2023
@bisgaard-itis
Copy link
Contributor Author

@pcrespov and @matusdrobuliak66 sorry for the many small PRs. This should be the last one to only concerning generation of the python client. Now I will start generating the C client.

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #4366 (6f32cef) into master (225bbca) will decrease coverage by 7.9%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4366      +/-   ##
=========================================
- Coverage    85.4%   77.6%    -7.9%     
=========================================
  Files         747      62     -685     
  Lines       32538    1773   -30765     
  Branches      457       0     -457     
=========================================
- Hits        27809    1376   -26433     
+ Misses       4633     397    -4236     
+ Partials       96       0      -96     
Flag Coverage Δ
unittests 77.6% <ø> (-7.9%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 685 files with indirect coverage changes

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 ! No need to apologize! Great contribution!

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem at all 👍

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) June 14, 2023 13:57
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Jun 15, 2023

Code Climate has analyzed commit 6f32cef and detected 0 issues on this pull request.

View more on Code Climate.

@bisgaard-itis bisgaard-itis merged commit 7ebcf27 into ITISFoundation:master Jun 15, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 22, 2023
34 tasks
@bisgaard-itis bisgaard-itis deleted the update-client-generation branch October 25, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:api framework api, data schemas,
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants