-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Enhancements for product-owner users and invitations #4862
✨ Enhancements for product-owner users and invitations #4862
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 6656 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 6666 lines exceeds the maximum allowed for the inline comments feature.
Codecov Report
@@ Coverage Diff @@
## master #4862 +/- ##
========================================
- Coverage 86.8% 84.2% -2.6%
========================================
Files 1179 1179
Lines 48920 48981 +61
Branches 1063 1063
========================================
- Hits 42500 41283 -1217
- Misses 6185 7473 +1288
+ Partials 235 225 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
5452865
to
306249a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 6872 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 6899 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merci, I'll expose the object returned in get_product
services/web/server/src/simcore_service_webserver/products/_db.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Please find a few questions below.
services/web/server/tests/unit/with_dbs/03/products/test_products_handlers.py
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_webserver/product.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
services/static-webserver/client/source/class/osparc/po/Invitations.js
Outdated
Show resolved
Hide resolved
57dff06
to
93d83c9
Compare
Code Climate has analyzed commit 1be7019 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed!
|
What do these changes do?
wallet_name=f"{user_name} Credits"
description=f"Credits purchased by {user_name} end up in here"
generate_invitation
fieldextra_credits
is renamed asextra_credits_in_usd
Product
modelproduct.credits_per_usd
, i.e. number of credits per dollarget_product
entrypoints restricted toPRODUCT_OWNERS
PO center
Detail on
get_product
More details in
products
section of openapi.json swaggerRelated issue/s
How to test
Driving tests:
tests/unit/with_dbs/03/wallets/test_wallets.py::test_wallets_events_auto_add_default_wallet_on_user_confirmation
tests/unit/with_dbs/03/invitations/test_products_invitations.py
tests/unit/with_dbs/03/products/test_products_handlers.py
DevOps
None