Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 e2e/support multiple jupyterlabs #5319

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Feb 8, 2024

What do these changes do?

  • 🎨 e2e/support multiple jupyterlabs (math and smash)

Related issue/s

How to test

Dev Checklist

DevOps Checklist

matusdrobuliak66 and others added 30 commits November 10, 2023 15:49
…iak66/osparc-simcore into is922/auto-recharge-emit-msg
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (195c0d0) 87.3% compared to head (839b69f) 65.0%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5319      +/-   ##
=========================================
- Coverage    87.3%   65.0%   -22.3%     
=========================================
  Files        1320     542     -778     
  Lines       54063   27166   -26897     
  Branches     1172     202     -970     
=========================================
- Hits        47201   17660   -29541     
- Misses       6612    9456    +2844     
+ Partials      250      50     -200     
Flag Coverage Δ
integrationtests 65.0% <ø> (+<0.1%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1114 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review February 8, 2024 15:46
@matusdrobuliak66 matusdrobuliak66 self-assigned this Feb 8, 2024
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the urgency but please consider my suggestions :-)
thx

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, my suggestion is optional

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@matusdrobuliak66 matusdrobuliak66 merged commit 0db8ce7 into ITISFoundation:master Feb 12, 2024
55 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the e2e/support-multiple-jupyterlabs branch February 12, 2024 09:49
@matusdrobuliak66 matusdrobuliak66 added this to the Schoggilebe milestone Feb 12, 2024
@matusdrobuliak66 matusdrobuliak66 added the t:maintenance Some planned maintenance work label Feb 12, 2024
jsaq007 pushed a commit to jsaq007/osparc-simcore that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants