♻️ Fixes deprecation warning of aiohttp client session

[pcrespov]

What do these changes do?

Fixes long standing deprecation warning on aiohttp.ClientSession() (more details in issue below). This change required a small redesign. This is the idea: Basically an aiohttp application created using app = create_safe_application() injects an event app.cleanup_ctx.append(persistent_client_session) to create an aiohttp.ClientSession that is attached to the lifespam of the application, i.e. a unique client session that is started and closed with the application. This is the only session used for all communications with other internal or external services. After the app starts, the session is ready and can be obtained using get_client_session. This pattern is used in all the aiohttp-based apps, i.e. web-server and storage.

This fix might unblock upgrading aiohttp #5206

• 🔥 Removes some duplicated tests.

Related issue/s

• resolves DeprecationWarning: ClientSession The object should be created within an async function #4628

How to test

• all tests in place of servicelib
• mainly covered packages/service-library/tests/aiohttp/test_application.py

Dev Checklist

• No ENV changes or I properly updated ENV (read the instruction)

DevOps Checklist

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c80cedd) 87.3% compared to head (4a0ba94) 87.3%.

Additional details and impacted files

@@           Coverage Diff            @@
##           master   #5321     +/-   ##
========================================
- Coverage    87.3%   87.3%   -0.1%     
========================================
  Files        1320    1320             
  Lines       54073   54063     -10     
  Branches     1174    1172      -2     
========================================
- Hits        47212   47202     -10     
- Misses       6610    6611      +1     
+ Partials      251     250      -1     

Flag	Coverage Δ
integrationtests	64.9% <44.4%> (-0.2%)	⬇️
unittests	85.1% <100.0%> (-0.1%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...e-library/src/servicelib/aiohttp/client_session.py	100.0% <100.0%> (+7.1%)	⬆️
...rage/src/simcore_service_storage/simcore_s3_dsm.py	94.7% <100.0%> (ø)
.../src/simcore_service_webserver/scicrunch/plugin.py	100.0% <100.0%> (ø)
...core_service_webserver/scicrunch/service_client.py	65.2% <100.0%> (+0.5%)	⬆️

... and 3 files with indirect coverage changes

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[matusdrobuliak66]

Thanks!

[sanderegg]

thanks

[bisgaard-itis]

Thanks a lot.