-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Allow a user to select from default project thumbnails #5334
✨ Allow a user to select from default project thumbnails #5334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very colourful ... even green (are you sure?)! :-)
thx
services/static-webserver/client/source/class/osparc/editor/ThumbnailSuggestions.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done. @pcrespov green is on me. An incentive to create proper ones...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If thumbnail is empty, it display like this
There is the layout problem, but I also don't get why do we want to show the same suggestions for all services... Doesn't a S4L service have different suggestions than a sleeper?
Also, if I use a URL in osparc.editor.ThumbnailSuggestions
that does not correspond to an existing image, an empty square is shown which can still be selected.
P.D.: Sometimes there is a thumbnail but the thumbnail suggestions are still shown very small...
services/static-webserver/client/source/class/osparc/editor/ThumbnailEditor.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/editor/ThumbnailSuggestions.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/editor/ThumbnailSuggestions.js
Outdated
Show resolved
Hide resolved
@ignapas This should now be resolved. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5334 +/- ##
========================================
- Coverage 87.4% 87.3% -0.2%
========================================
Files 1313 1321 +8
Lines 54035 54181 +146
Branches 1172 1172
========================================
+ Hits 47270 47323 +53
- Misses 6515 6608 +93
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
|
What do these changes do?
Allow users to see select thumbnails from services and from a default template list in the projects .

Related issue/s
How to test
Dev Checklist
DevOps Checklist