Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Allow a user to select from default project thumbnails #5334

Merged
merged 9 commits into from
Feb 21, 2024

Conversation

jsaq007
Copy link
Contributor

@jsaq007 jsaq007 commented Feb 14, 2024

What do these changes do?

Allow users to see select thumbnails from services and from a default template list in the projects .
2024-02-14 15 35 15

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@jsaq007 jsaq007 added a:frontend issue affecting the front-end (area group) UX_improvements UX Feedback during frontend testing process javascript UI/UX labels Feb 14, 2024
@jsaq007 jsaq007 added this to the Schoggilebe milestone Feb 14, 2024
@jsaq007 jsaq007 self-assigned this Feb 14, 2024
@jsaq007 jsaq007 requested a review from ignapas as a code owner February 14, 2024 15:50
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very colourful ... even green (are you sure?)! :-)
thx

Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. @pcrespov green is on me. An incentive to create proper ones...

@pcrespov pcrespov enabled auto-merge (squash) February 15, 2024 11:20
Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If thumbnail is empty, it display like this
image
There is the layout problem, but I also don't get why do we want to show the same suggestions for all services... Doesn't a S4L service have different suggestions than a sleeper?
Also, if I use a URL in osparc.editor.ThumbnailSuggestions that does not correspond to an existing image, an empty square is shown which can still be selected.
P.D.: Sometimes there is a thumbnail but the thumbnail suggestions are still shown very small...

@jsaq007
Copy link
Contributor Author

jsaq007 commented Feb 20, 2024

If thumbnail is empty, it display like this image There is the layout problem, but I also don't get why do we want to show the same suggestions for all services... Doesn't a S4L service have different suggestions than a sleeper? Also, if I use a URL in osparc.editor.ThumbnailSuggestions that does not correspond to an existing image, an empty square is shown which can still be selected. P.D.: Sometimes there is a thumbnail but the thumbnail suggestions are still shown very small...

@ignapas This should now be resolved.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a5a0a44) 87.4% compared to head (690d48f) 87.3%.

❗ Current head 690d48f differs from pull request most recent head 92066b9. Consider uploading reports for the commit 92066b9 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #5334     +/-   ##
========================================
- Coverage    87.4%   87.3%   -0.2%     
========================================
  Files        1313    1321      +8     
  Lines       54035   54181    +146     
  Branches     1172    1172             
========================================
+ Hits        47270   47323     +53     
- Misses       6515    6608     +93     
  Partials      250     250             
Flag Coverage Δ
integrationtests 64.9% <77.4%> (-0.1%) ⬇️
unittests 85.2% <90.2%> (-0.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/simcore_service_autoscaling/core/application.py 97.8% <100.0%> (-2.2%) ⬇️
...g/src/simcore_service_autoscaling/core/settings.py 97.9% <100.0%> (ø)
...e_service_autoscaling/modules/auto_scaling_core.py 94.3% <100.0%> (ø)
...vice_autoscaling/modules/auto_scaling_mode_base.py 81.4% <100.0%> (ø)
...scaling/modules/auto_scaling_mode_computational.py 91.0% <100.0%> (ø)
...e_autoscaling/modules/auto_scaling_mode_dynamic.py 100.0% <100.0%> (ø)
.../simcore_service_autoscaling/utils/utils_docker.py 99.1% <100.0%> (ø)
...rc/simcore_service_webserver/payments/_socketio.py 100.0% <100.0%> (ø)
...simcore_service_webserver/projects/projects_api.py 84.3% <100.0%> (ø)
...rc/simcore_service_webserver/socketio/_handlers.py 85.8% <100.0%> (ø)
... and 3 more

... and 29 files with indirect coverage changes

@jsaq007 jsaq007 requested a review from ignapas February 20, 2024 12:53
Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pcrespov pcrespov merged commit 283e6b5 into ITISFoundation:master Feb 21, 2024
49 checks passed
jsaq007 added a commit to jsaq007/osparc-simcore that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) UI/UX UX_improvements UX Feedback during frontend testing process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default project thumbnails Dashboard; list views have low contrast
7 participants