🐛 Remove quotes around "/data" in MINIO_VOLUMES var #5351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaving quotes around this path, makes docker compose translate this into '"/data"', which generates a path with quotes in it, and makes minio store data in its container instead of the minio volume
wvangeit
added
bug
wvangeit
requested review from
sanderegg,
mrnicegyu11 and
YuryHrytsuk
as code owners
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5351 +/- ##
========================================
- Coverage 87.5% 87.4% -0.1%
========================================
Files 1096 1313 +217
Lines 46981 54034 +7053
Branches 632 1172 +540
========================================
+ Hits 41132 47258 +6126
- Misses 5718 6526 +808
- Partials 131 250 +119
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
For future reference: docker/compose#2854 |
jsaq007
pushed a commit
to jsaq007/osparc-simcore
that referenced
this pull request
Feb 22, 2024
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving quotes around this path, makes docker compose translate this into '"/data"', which generates a path with quotes in it, and makes minio store data in its container instead of the minio volume
What do these changes do?
Remove the quotes around "/data" in docker compose
How to test
(at least for Docker Compose version v2.24.5)
Enable minio in a local deployment. Run:
make up-prod
Put some data in the minio store, but for example uploading some file to a local osparc study. Run:
make down; make leave; make down;
Next time when run make up-prod, the data in Minio is gone.
One can also attach to the minio container with portainer, and verify the location of the data. After the fix it should be in /data, before the fix the data will be in a directory called '"' in the /
Dev Checklist
DevOps Checklist