-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix wrong project order_by of 'name' field #5356
🐛 fix wrong project order_by of 'name' field #5356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5356 +/- ##
=========================================
- Coverage 87.4% 80.9% -6.5%
=========================================
Files 1313 539 -774
Lines 54034 27119 -26915
Branches 1172 202 -970
=========================================
- Hits 47259 21957 -25302
+ Misses 6525 5112 -1413
+ Partials 250 50 -200
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
What do these changes do?
users
table in the db query so we can do full text search for example ofname
column inusers
table. When the client in addition provides also the order_by query parameter and is interested in thename
field (which is provided byproject.name
) then the order by query was sorted byusers.name
and notprojects.name
. This PR fixes it.@jsaq007 This is the fix for the issue reported by you
Related issue/s
How to test
pytest tests/unit/with_dbs/02/test_projects_crud_handlers__list_with_query_params.py
Dev Checklist
DevOps Checklist