-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ποΈ New templates to products map table #5358
ποΈ New templates to products map table #5358
Conversation
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## master #5358 +/- ##
========================================
+ Coverage 86.8% 87.4% +0.5%
========================================
Files 1186 1316 +130
Lines 49070 54084 +5014
Branches 923 1174 +251
========================================
+ Hits 42639 47312 +4673
- Misses 6234 6522 +288
- Partials 197 250 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thank you I like these faker modules. I think we might be able to remove a load of code using them. Just a few questions. Thanks!
packages/pytest-simcore/src/pytest_simcore/faker_products_data.py
Outdated
Show resolved
Hide resolved
packages/pytest-simcore/src/pytest_simcore/faker_products_data.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
|
What do these changes do?
In preparation to load email templates from the database, this PR introduces a new table to map
products
withtemplates
.products_to_templates
tablefaker_*_data
fixtures for users, products and payments data. They have the following properties:Related issue/s
How to test
Driving test
products/test_products_to_templates.py
Dev Checklist
DevOps Checklist