Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ—ƒοΈ New templates to products map table #5358

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Feb 21, 2024

What do these changes do?

In preparation to load email templates from the database, this PR introduces a new table to map products with templates.

  • πŸ—ƒοΈ New products_to_templates table
  • Testing: Convenient faker_*_data fixtures for users, products and payments data. They have the following properties:
    • self-consistent, i.e. the values of all fixtures are coupled
    • granular, i.e. test suites can override at different levels

Related issue/s

How to test

Driving test products/test_products_to_templates.py

Dev Checklist

DevOps Checklist

@pcrespov pcrespov changed the title 🎨 New templates to products map table πŸ—ƒοΈ πŸ—ƒοΈ New templates to products map table Feb 21, 2024
@pcrespov pcrespov self-assigned this Feb 21, 2024
@pcrespov pcrespov added the a:database associated to postgres service and postgres-database package label Feb 21, 2024
@pcrespov pcrespov added this to the Schoggilebe milestone Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (226c183) 86.8% compared to head (ecd2e27) 87.4%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #5358     +/-   ##
========================================
+ Coverage    86.8%   87.4%   +0.5%     
========================================
  Files        1186    1316    +130     
  Lines       49070   54084   +5014     
  Branches      923    1174    +251     
========================================
+ Hits        42639   47312   +4673     
- Misses       6234    6522    +288     
- Partials      197     250     +53     
Flag Coverage Ξ”
integrationtests 65.0% <ΓΈ> (-0.1%) ⬇️
unittests 85.3% <100.0%> (+0.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
...se/src/simcore_postgres_database/models/_common.py 100.0% <ΓΈ> (ΓΈ)
..._postgres_database/models/products_to_templates.py 100.0% <100.0%> (ΓΈ)
...es-database/src/simcore_postgres_database/utils.py 72.2% <ΓΈ> (ΓΈ)

... and 134 files with indirect coverage changes

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thank you I like these faker modules. I think we might be able to remove a load of code using them. Just a few questions. Thanks!

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@pcrespov pcrespov enabled auto-merge (squash) February 22, 2024 10:06
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pcrespov pcrespov merged commit e375471 into ITISFoundation:master Feb 22, 2024
55 checks passed
@pcrespov pcrespov deleted the is5227/new-template-to-product-table branch February 22, 2024 15:21
jsaq007 pushed a commit to jsaq007/osparc-simcore that referenced this pull request Feb 27, 2024
jsaq007 pushed a commit to jsaq007/osparc-simcore that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:database associated to postgres service and postgres-database package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants