🎨 adding optional override of dnsrr mode for testing purpose on master (⚠️ devops) #5363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matusdrobuliak66
requested review from
sanderegg,
mrnicegyu11,
YuryHrytsuk,
pcrespov and
GitHK
as code owners
sanderegg
approved these changes
Feb 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5363 +/- ##
========================================
+ Coverage 83.9% 86.8% +2.8%
========================================
Files 1302 1316 +14
Lines 53341 54087 +746
Branches 1174 1174
========================================
+ Hits 44767 46949 +2182
+ Misses 8324 6888 -1436
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more.
|
GitHK
approved these changes
Feb 22, 2024
services/director-v2/src/simcore_service_director_v2/core/dynamic_services_settings/sidecar.py
Outdated
Show resolved
Hide resolved
|
Does it require ENV changes? |
pcrespov
approved these changes
Feb 22, 2024
services/director-v2/src/simcore_service_director_v2/core/dynamic_services_settings/sidecar.py
Outdated
Show resolved
Hide resolved
https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/423 |
…ub.com:matusdrobuliak66/osparc-simcore into experiment/changing-sidecar-endpoint-spec-mode
|
1 similar comment
|
YuryHrytsuk
approved these changes
Feb 23, 2024
21 tasks
jsaq007
pushed a commit
to jsaq007/osparc-simcore
that referenced
this pull request
Feb 27, 2024
jsaq007
pushed a commit
to jsaq007/osparc-simcore
that referenced
this pull request
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue/s
How to test
Dev Checklist
DevOps Checklist
DYNAMIC_SIDECAR_ENDPOINT_SPECS_MODE_DNSRR_ENABLED