-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 removing jupyterlab flaky part of the e2e test #5371
🎨 removing jupyterlab flaky part of the e2e test #5371
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5371 +/- ##
=========================================
- Coverage 87.5% 65.0% -22.5%
=========================================
Files 1317 539 -778
Lines 54175 27178 -26997
Branches 1176 203 -973
=========================================
- Hits 47407 17690 -29717
- Misses 6518 9437 +2919
+ Partials 250 51 -199
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I guess
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
I'm curious to see why jupyter-math specifically is flaky (doesn't the jupyterlab UI show up correctly?). I'll check if I can spot some meaningful playwrite tests.
no no the UI shows correctly. The test is written not in a stable way meaning that sometimes when he is looking for the jupyter math button he doesn't see it
this line of code needs to be written differently, but I do not know yet how. |
What do these changes do?
Related issue/s
How to test
Dev Checklist
DevOps Checklist