-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Update docker service hostname #5379
♻️ Update docker service hostname #5379
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5379 +/- ##
========================================
- Coverage 87.5% 86.8% -0.7%
========================================
Files 1318 1318
Lines 54197 54197
Branches 1176 1176
========================================
- Hits 47432 47059 -373
- Misses 6515 6888 +373
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more. |
services/clusters-keeper/src/simcore_service_clusters_keeper/data/docker-compose.yml
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good I hope it works thx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. Let's see how this play with postgres client names. When it is deployed we can check that together.
thx
What do these changes do?
Use
hostname: "{{.Node.Hostname}}"
for every service to avoid having 65+ char long names which docker cannot process.Related issue/s
Example of problems it caused so far:
dynamic-scheduler
fails to start on TIP osparc-ops-environments#503How to test
Dev Checklist
DevOps Checklist