Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Update docker service hostname #5379

Merged

Conversation

YuryHrytsuk
Copy link
Contributor

@YuryHrytsuk YuryHrytsuk commented Feb 27, 2024

What do these changes do?

Use hostname: "{{.Node.Hostname}}" for every service to avoid having 65+ char long names which docker cannot process.

Related issue/s

Example of problems it caused so far:

How to test

Dev Checklist

DevOps Checklist

@YuryHrytsuk YuryHrytsuk enabled auto-merge (squash) February 27, 2024 10:22
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.8%. Comparing base (bc02e83) to head (66ceb5d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #5379     +/-   ##
========================================
- Coverage    87.5%   86.8%   -0.7%     
========================================
  Files        1318    1318             
  Lines       54197   54197             
  Branches     1176    1176             
========================================
- Hits        47432   47059    -373     
- Misses       6515    6888    +373     
  Partials      250     250             
Flag Coverage Δ
integrationtests 60.7% <ø> (-4.4%) ⬇️
unittests 85.3% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes

@YuryHrytsuk YuryHrytsuk requested a review from pcrespov February 27, 2024 12:43
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good I hope it works thx!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. Let's see how this play with postgres client names. When it is deployed we can check that together.
thx

@YuryHrytsuk YuryHrytsuk merged commit 347ccc6 into ITISFoundation:master Feb 27, 2024
54 checks passed
@YuryHrytsuk YuryHrytsuk deleted the shorten-services-hostname branch February 27, 2024 13:22
jsaq007 pushed a commit to jsaq007/osparc-simcore that referenced this pull request Feb 27, 2024
jsaq007 pushed a commit to jsaq007/osparc-simcore that referenced this pull request Feb 27, 2024
jsaq007 pushed a commit to jsaq007/osparc-simcore that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure that hostname length is not greater than 255 chars
4 participants