-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👽️ ✨ document status codes in api server #5386
👽️ ✨ document status codes in api server #5386
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5386 +/- ##
=========================================
- Coverage 87.5% 66.0% -21.6%
=========================================
Files 1322 618 -704
Lines 54234 30020 -24214
Branches 1175 204 -971
=========================================
- Hits 47479 19814 -27665
- Misses 6506 10154 +3648
+ Partials 249 52 -197
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, this goes in a nice direction. I will contribute later to it with automatic generation of those from error handler mapping mechanism i am creating as well
Left some suggestions
services/api-server/src/simcore_service_api_server/api/routes/files.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/routes/files.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good but please double check the ErrorGet model issue I comment before merging.
Let me know if you want to look at it together.
thx!
services/api-server/src/simcore_service_api_server/api/routes/files.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/api/routes/files.py
Outdated
Show resolved
Hide resolved
|
What do these changes do?
Related issue/s
How to test
Dev Checklist
DevOps Checklist