Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

director-v2's dynamic scheduler monitoring task runs exclusively #5401

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Mar 1, 2024

What do these changes do?

Makes sure the sidecars monitoring task runs only 1 copy across all instances of running director-v2.

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@GitHK GitHK self-assigned this Mar 1, 2024
@GitHK GitHK added the a:director-v2 issue related with the director-v2 service label Mar 1, 2024
@GitHK GitHK modified the milestone: Schoggilebe Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.5%. Comparing base (2aa73cc) to head (45fd436).
Report is 12 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5401      +/-   ##
=========================================
- Coverage    87.5%   41.5%   -46.1%     
=========================================
  Files        1322     324     -998     
  Lines       54234   15524   -38710     
  Branches     1175       0    -1175     
=========================================
- Hits        47479    6443   -41036     
- Misses       6506    9081    +2575     
+ Partials      249       0     -249     
Flag Coverage Δ
integrationtests 41.5% <ø> (-23.7%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1245 files with indirect coverage changes

@GitHK GitHK changed the title adds exclusive create task director-v2's dynamic scheduler monitoring task runs exclusively Mar 4, 2024
@GitHK GitHK added this to the Schoggilebe milestone Mar 4, 2024
@GitHK GitHK marked this pull request as ready for review March 5, 2024 12:50
@GitHK GitHK requested review from sanderegg and pcrespov as code owners March 5, 2024 12:50
@GitHK GitHK requested a review from matusdrobuliak66 March 5, 2024 12:50
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice ! thanks!

Andrei Neagu added 2 commits March 5, 2024 13:56
…HK/osparc-simcore-forked into pr-osparc-director-v2-exclusive-task
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx.
Left some suggestions to improve the code maintenance.

Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@GitHK GitHK merged commit f523571 into ITISFoundation:master Mar 5, 2024
55 checks passed
@GitHK GitHK deleted the pr-osparc-director-v2-exclusive-task branch March 5, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants