-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
director-v2
's dynamic scheduler monitoring task runs exclusively
#5401
director-v2
's dynamic scheduler monitoring task runs exclusively
#5401
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5401 +/- ##
=========================================
- Coverage 87.5% 41.5% -46.1%
=========================================
Files 1322 324 -998
Lines 54234 15524 -38710
Branches 1175 0 -1175
=========================================
- Hits 47479 6443 -41036
- Misses 6506 9081 +2575
+ Partials 249 0 -249
Flags with carried forward coverage won't be shown. Click here to find out more. |
…r-v2-exclusive-task
…r-v2-exclusive-task
…r-v2-exclusive-task
…r-v2-exclusive-task
director-v2
's dynamic scheduler monitoring task runs exclusively
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice ! thanks!
…HK/osparc-simcore-forked into pr-osparc-director-v2-exclusive-task
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx.
Left some suggestions to improve the code maintenance.
...ices/director-v2/src/simcore_service_director_v2/core/dynamic_services_settings/scheduler.py
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/api_keys_manager.py
Outdated
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/api_keys_manager.py
Show resolved
Hide resolved
...tor-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_scheduler.py
Outdated
Show resolved
Hide resolved
...tor-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_scheduler.py
Outdated
Show resolved
Hide resolved
...tor-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_scheduler.py
Outdated
Show resolved
Hide resolved
|
What do these changes do?
Makes sure the sidecars monitoring task runs only 1 copy across all instances of running director-v2.
Related issue/s
How to test
Dev Checklist
DevOps Checklist